Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-833] New airflow default_config command #5012

Closed
wants to merge 4 commits into from
Closed

[AIRFLOW-833] New airflow default_config command #5012

wants to merge 4 commits into from

Conversation

gsakkis
Copy link
Contributor

@gsakkis gsakkis commented Mar 30, 2019

Follow up from #2052 after syncing with latest master. In addition to the new command, this PR defers the dir/file creation that takes place at import time (airflow.cfg, unittests.cfg, webserver_config.py, airflow.db, logs/)

- Generate the default airflow.cfg explicitly, not when simply importing airflow.
- The default airflow.cfg is also created on `airflow initdb`
  if it doesn't exist already.
- Don't create the unittests.cfg unless unit_test_mode is true.
Still to have things work out of the box, we need to mkdir
the sqlite's parent directory on initdb cli command
@codecov-io
Copy link

codecov-io commented Mar 31, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@979f452). Click here to learn what that means.
The diff coverage is 90.62%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5012   +/-   ##
=========================================
  Coverage          ?   75.76%           
=========================================
  Files             ?      461           
  Lines             ?    29961           
  Branches          ?        0           
=========================================
  Hits              ?    22701           
  Misses            ?     7260           
  Partials          ?        0
Impacted Files Coverage Δ
airflow/www/app.py 97.45% <100%> (ø)
airflow/bin/cli.py 67.17% <100%> (ø)
airflow/utils/db.py 90.74% <100%> (ø)
airflow/www/views.py 76.09% <60%> (ø)
airflow/utils/log/file_processor_handler.py 83.33% <85.71%> (ø)
airflow/configuration.py 93.1% <96%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 979f452...6b6a891. Read the comment docs.

@OmerJog
Copy link
Contributor

OmerJog commented Jun 20, 2019

@ashb can take a look?

@stale
Copy link

stale bot commented Sep 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 3, 2019
@stale stale bot closed this Sep 11, 2019
@dimberman dimberman reopened this Mar 29, 2020
@stale stale bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Mar 29, 2020
@dimberman dimberman closed this Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants