Add MaxComputeSQLOperator, MaxComputeHook and AlibabaBaseHook to Alibaba Provider #50178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjasonseba
changed the title
jsjasonseba
force-pushed
the
alibaba-provider-maxcompute
branch
from
a46a838 to
83540fb
Compare
jsjasonseba
changed the title
Contributor
Author
|
Hi @eladkal, |
Contributor
Author
Contributor
Author
|
Hi @Lee-W @hussein-awala , would you mind reviewing this PR? |
Member
Will take a look 🙂 |
Lee-W
reviewed
May 19, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
not yet finish the whole review but left a few comments
providers/alibaba/src/airflow/providers/alibaba/cloud/hooks/base_alibaba.py
Show resolved
Hide resolved
providers/alibaba/src/airflow/providers/alibaba/cloud/hooks/base_alibaba.py
Outdated
Show resolved
Hide resolved
providers/alibaba/src/airflow/providers/alibaba/cloud/hooks/maxcompute.py
Outdated
Show resolved
Hide resolved
providers/alibaba/src/airflow/providers/alibaba/cloud/hooks/maxcompute.py
Outdated
Show resolved
Hide resolved
providers/alibaba/src/airflow/providers/alibaba/cloud/hooks/maxcompute.py
Outdated
Show resolved
Hide resolved
providers/alibaba/src/airflow/providers/alibaba/cloud/hooks/maxcompute.py
Outdated
Show resolved
Hide resolved
providers/alibaba/src/airflow/providers/alibaba/cloud/hooks/maxcompute.py
Show resolved
Hide resolved
providers/alibaba/src/airflow/providers/alibaba/cloud/hooks/maxcompute.py
Outdated
Show resolved
Hide resolved
providers/alibaba/src/airflow/providers/alibaba/cloud/hooks/maxcompute.py
Outdated
Show resolved
Hide resolved
providers/alibaba/src/airflow/providers/alibaba/cloud/operators/maxcompute.py
Show resolved
Hide resolved
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W
reviewed
May 22, 2025
providers/alibaba/src/airflow/providers/alibaba/cloud/hooks/maxcompute.py
Outdated
Show resolved
Hide resolved
Lee-W
reviewed
May 22, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
mostly good, left a few nitpicks 🙂
providers/alibaba/src/airflow/providers/alibaba/cloud/operators/maxcompute.py
Show resolved
Hide resolved
providers/alibaba/src/airflow/providers/alibaba/cloud/operators/maxcompute.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Contributor
Author
|
Made some adjustment to |
Lee-W
reviewed
May 28, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
Mostly looks good. left a few nits
providers/alibaba/src/airflow/providers/alibaba/cloud/hooks/maxcompute.py
Outdated
Show resolved
Hide resolved
providers/alibaba/src/airflow/providers/alibaba/cloud/hooks/maxcompute.py
Outdated
Show resolved
Hide resolved
providers/alibaba/tests/unit/alibaba/cloud/hooks/test_maxcompute.py
Outdated
Show resolved
Hide resolved
Lee-W
approved these changes
May 30, 2025
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
…aba Provider (apache#50178) * Add MaxComputeHook and AlibabaBaseHook * Remove unecessary init override * Fix word spelling * Add type hints and docstrings to MaxComputeHook and AlibabaBaseHook * Set priority from hints if not explicitly provided * Add odps to spelling wordlist * Add stop_instance method to MaxComputeHook * Add MaxComputeSQLOperator * Fix docstring * Add maxcompute to wordlist * Add alibaba test_version_compat.py to overlooked test list * Add test for MaxComputeLogViewLink * Simplify fallback logic Co-authored-by: Wei Lee <weilee.rx@gmail.com> * Change error logging to use log.exception Co-authored-by: Wei Lee <weilee.rx@gmail.com> * Simplify logics * Make arguments keyword-only * Create MaxComputeConfigurationException for configuration issues * Add test for MaxComputeConfigurationException * Simplify code Co-authored-by: Wei Lee <weilee.rx@gmail.com> * Simplify code * Simplify code * Adjust connection arg name for styling consistency with other hooks * Adjust connection arg name for styling consistency with other hooks * Refactor code * Refactor code --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jose-lehmkuhl
pushed a commit
to jose-lehmkuhl/airflow
that referenced
this pull request
Jul 11, 2025
…aba Provider (apache#50178) * Add MaxComputeHook and AlibabaBaseHook * Remove unecessary init override * Fix word spelling * Add type hints and docstrings to MaxComputeHook and AlibabaBaseHook * Set priority from hints if not explicitly provided * Add odps to spelling wordlist * Add stop_instance method to MaxComputeHook * Add MaxComputeSQLOperator * Fix docstring * Add maxcompute to wordlist * Add alibaba test_version_compat.py to overlooked test list * Add test for MaxComputeLogViewLink * Simplify fallback logic Co-authored-by: Wei Lee <weilee.rx@gmail.com> * Change error logging to use log.exception Co-authored-by: Wei Lee <weilee.rx@gmail.com> * Simplify logics * Make arguments keyword-only * Create MaxComputeConfigurationException for configuration issues * Add test for MaxComputeConfigurationException * Simplify code Co-authored-by: Wei Lee <weilee.rx@gmail.com> * Simplify code * Simplify code * Adjust connection arg name for styling consistency with other hooks * Adjust connection arg name for styling consistency with other hooks * Refactor code * Refactor code --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new operator
MaxComputeSQLOperatorand two new hooksMaxComputeHookandAlibabaBaseHookto the Alibaba Provider.MaxComputeis a fully-managed data warehouse solution provided by Alibaba Cloud.The
MaxComputeSQLOperatorprovides functionality to execute SQL statements in MaxCompute.The
MaxComputeHookprovides initial functionality, includingrun_sql,get_instance, andstop_instance.Additional hook methods, operators, and deferrable mode are next inline for development.
Most of Alibaba services relies on similar access key authentication. The
AlibabaBaseHookserves as a utility base class providing access key credential and base connection form, supporting the MaxComputeHook and other hooks to be implemented in the future. Existing hooks such asOSSHookmay benefit from refactoring to leverageAlibabaBaseHookdue to similar auth mechanism.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.