Always Show Trendcount in Dag Overview #50183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominic-lcw
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
dominic-lcw
changed the title
pierrejeambrun
approved these changes
May 5, 2025
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Nice, just a couple of small suggestions
airflow-core/src/airflow/ui/src/components/Assets/AssetEvents.tsx
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/src/components/Assets/AssetEvents.tsx
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/src/pages/Dag/Overview/Overview.tsx
Outdated
Show resolved
Hide resolved
bbovenzi
reviewed
May 5, 2025
Contributor
bbovenzi
left a comment
bbovenzi
left a comment
There was a problem hiding this comment.
Sounds good. Let's also update pages/Task/Overview while we're at it
Contributor
Author
Added the trendCount in taskOverview Before.
After
|
bbovenzi
reviewed
May 6, 2025
airflow-core/src/airflow/ui/src/components/Assets/AssetEvents.tsx
Outdated
Show resolved
Hide resolved
bbovenzi
approved these changes
May 6, 2025
ayush3singh
pushed a commit
to ayush3singh/airflow
that referenced
this pull request
May 8, 2025
* always show trendcount * only override margin left of assetevents for overview.tsx * update AssetEvent props * Update task overview.tsx also * update typehints for general props
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
* always show trendcount * only override margin left of assetevents for overview.tsx * update AssetEvent props * Update task overview.tsx also * update typehints for general props (cherry picked from commit 9096456)
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
* always show trendcount * only override margin left of assetevents for overview.tsx * update AssetEvent props * Update task overview.tsx also * update typehints for general props (cherry picked from commit 9096456)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im not sure if we hide TrendCount when failed counts == 0 on purpose.
Im thinking would it be better to show more summary info, starting with trendCount first. Just my proposal. Thanks!
Previous
Not showing trendcount when nothing failed.
New
We can show trendcount by default.
On failed, change back to "failed" color.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.