Add basic json check to variable value #50277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
shubhamraj-git
approved these changes
May 6, 2025
ayush3singh
pushed a commit
to ayush3singh/airflow
that referenced
this pull request
May 8, 2025
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
(cherry picked from commit 8934641)
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
(cherry picked from commit 8934641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't know if a Variable value is going to be json, but if it starts with
{or[we can at least try to check and show the user a warning they can choose to listen to or not.Also, made sure the value was actually a required field.
Closes #27157
See the difference between an error and a warning:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.