Add in-memory buffer and gzip support in SqlToS3Operator #50287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
jason810496
reviewed
May 7, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Thanks for the PR! Only small question about the compression part and encoding for TextIOWrapper.
providers/amazon/src/airflow/providers/amazon/aws/transfers/sql_to_s3.py
Show resolved
Hide resolved
providers/amazon/src/airflow/providers/amazon/aws/transfers/sql_to_s3.py
Outdated
Show resolved
Hide resolved
james5418
force-pushed
the
fix-high-memory-usage-and-temp-file-name-leak-in-SqlToS3Operator
branch
from
e1aae82 to
3e62bda
Compare
james5418
force-pushed
the
fix-high-memory-usage-and-temp-file-name-leak-in-SqlToS3Operator
branch
from
3e62bda to
8f7d4d4
Compare
vincbeck
approved these changes
May 12, 2025
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* replace NamedTemporaryFile with in-memory buffer for S3 uploads and add gzip support * add UTF-8 encoding to TextIOWrapper * update mock method from get_pandas_df to get_df in SqlToS3Operator tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed: #50159
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.