Migrate BigQueryHook to use get_df
#50341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
eladkal
reviewed
May 8, 2025
providers/google/tests/unit/google/cloud/hooks/test_bigquery_system.py
Outdated
Show resolved
Hide resolved
MaksYermak
suggested changes
May 8, 2025
providers/google/src/airflow/providers/google/cloud/hooks/bigquery.py
Outdated
Show resolved
Hide resolved
MaksYermak
suggested changes
May 8, 2025
providers/google/src/airflow/providers/google/cloud/hooks/bigquery.py
Outdated
Show resolved
Hide resolved
guan404ming
force-pushed
the
migrate-bgq
branch
3 times, most recently
from
74156ba to
50c7cf9
Compare
Co-authored-by: maks.yermakou@gmail.com Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
16 tasks
MaksYermak
approved these changes
May 12, 2025
Member
Author
|
Thanks for all reviews and suggestions! |
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* Migrate `BigQueryHook` to use `get_df` * Update test and deprecated Co-authored-by: maks.yermakou@gmail.com Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com> * Remove unused mock * Update synchronous func and test * Update type overload --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
get_pandas_dftoget_dfinproviders#49334Why
get_pandas_dfdeprecated in #48875, which would be replaced byget_df. Thus, we need to migrate them in providers.How
BigQueryHook^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.