Raise exception if downgrade can't proceed due to no ab_user table
#50343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
approved these changes
May 8, 2025
ephraimbuddy
force-pushed
the
raise-exception-vs-logging
branch
from
71bfdad to
ae37785
Compare
ephraimbuddy
added
the
backport-to-v3-1-test
We only log the error that the downgrade can't proceed if the `ab_user` table is not found, but we should raise an exception instead. Currently, the CI migrations don't exit on error, which prevents the necessary tests from running. Also updated the CI migration tests to export DB manager at the shell because it seems that's not happening, hence why downgrade is running correctly.
ephraimbuddy
force-pushed
the
raise-exception-vs-logging
branch
from
ae37785 to
e8cc34b
Compare
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2025
…user` table (#50343) * Raise exception if downgrade can't proceed due to no `ab_user` table We only log the error that the downgrade can't proceed if the `ab_user` table is not found, but we should raise an exception instead. Currently, the CI migrations don't exit on error, which prevents the necessary tests from running. Also updated the CI migration tests to export DB manager at the shell because it seems that's not happening, hence why downgrade is running correctly. * result can be none so check before accessing row_count * dont raise in unittest mode (cherry picked from commit 0f0fc02) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
Backport successfully created: v3-0-test
|
kaxil
pushed a commit
that referenced
this pull request
May 12, 2025
…user` table (#50343) * Raise exception if downgrade can't proceed due to no `ab_user` table We only log the error that the downgrade can't proceed if the `ab_user` table is not found, but we should raise an exception instead. Currently, the CI migrations don't exit on error, which prevents the necessary tests from running. Also updated the CI migration tests to export DB manager at the shell because it seems that's not happening, hence why downgrade is running correctly. * result can be none so check before accessing row_count * dont raise in unittest mode (cherry picked from commit 0f0fc02) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
kaxil
pushed a commit
that referenced
this pull request
May 12, 2025
…user` table (#50343) (#50351) * Raise exception if downgrade can't proceed due to no `ab_user` table We only log the error that the downgrade can't proceed if the `ab_user` table is not found, but we should raise an exception instead. Currently, the CI migrations don't exit on error, which prevents the necessary tests from running. Also updated the CI migration tests to export DB manager at the shell because it seems that's not happening, hence why downgrade is running correctly. * result can be none so check before accessing row_count * dont raise in unittest mode (cherry picked from commit 0f0fc02) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
…user` table (#50343) (#50351) * Raise exception if downgrade can't proceed due to no `ab_user` table We only log the error that the downgrade can't proceed if the `ab_user` table is not found, but we should raise an exception instead. Currently, the CI migrations don't exit on error, which prevents the necessary tests from running. Also updated the CI migration tests to export DB manager at the shell because it seems that's not happening, hence why downgrade is running correctly. * result can be none so check before accessing row_count * dont raise in unittest mode (cherry picked from commit 0f0fc02) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only log the error that the downgrade can't proceed if the
ab_usertable is not found, but we should raise an exception instead. Currently, the CI migrations don't exit on error, which prevents the necessary tests from running.Also updated the CI migration tests to export DB manager at the shell because it seems that's not happening, hence why downgrade is running correctly.