Use non-deprecated context in tests for Airflow 3 #50391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
reviewed
May 9, 2025
Member
kaxil
left a comment
kaxil
left a comment
There was a problem hiding this comment.
Looks like there are few more:
airflow-core/src/airflow/example_dags/tutorial_taskflow_templates.py:from airflow.providers.standard.operators.python import get_current_context
airflow-core/tests/unit/models/test_mappedoperator.py:from airflow.providers.standard.operators.python import get_current_context
airflow-core/tests/unit/models/test_mappedoperator.py:from airflow.providers.standard.operators.python import get_current_context
airflow-core/tests/unit/models/test_taskinstance.py:from airflow.providers.standard.operators.python import get_current_context
providers/amazon/tests/system/amazon/aws/example_sagemaker.py:from airflow.providers.standard.operators.python import get_current_context
providers/standard/src/airflow/providers/standard/operators/python.py:from airflow.providers.standard.operators.python import get_current_context
potiuk
force-pushed
the
fix-failing-main-on-get-current-context-warning
branch
from
d58ac01 to
870f1c0
Compare
kaxil
reviewed
May 9, 2025
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
The apache#50301 deprecated using get_current_context in standard provider in favour of the task.sdk call, but some core tests are still using the provider's one.
potiuk
force-pushed
the
fix-failing-main-on-get-current-context-warning
branch
from
2eee613 to
9da3d76
Compare
kaxil
reviewed
May 9, 2025
providers/snowflake/src/airflow/providers/snowflake/operators/snowpark.py
Outdated
Show resolved
Hide resolved
kaxil
reviewed
May 9, 2025
Member
|
Merged it, simple change and unblocks main |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #50301 deprecated using get_current_context in standard provider in favour of the task.sdk call, but some core tests are still using the provider's one.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.