Support For Edge Worker in Daemon Mode #50425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:edge
dheerajturaga
commented
May 10, 2025
dheerajturaga
commented
May 10, 2025
jscheffl
reviewed
May 10, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Looks good ans thanks for the addition!
Can you also please adjust the docs so that people know about this, probably for example in providers/edge3/docs/deployment.rst ?
providers/edge3/src/airflow/providers/edge3/cli/edge_command.py
Outdated
Show resolved
Hide resolved
Member
Author
|
@jscheffl , I updated the docs highlighting this feature. I also added worker umask to the args list (aligning with celery) |
jscheffl
reviewed
May 11, 2025
providers/edge3/src/airflow/providers/edge3/cli/edge_command.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
jscheffl
approved these changes
May 11, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Thanks for the contribution - and the patience is rework! I think this is a very good extension! LGTM!
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* Support Edge Worker in Daemon Mode * Default daemon to false in EdgeWorkerCli * Update docs and add umask to worker command * cleaner umask selection Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * Add worker_umask to provider.yaml * Better help message for log files Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> --------- Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edge Worker (EdgeExecutor) runs in the foreground today. This PR extends the ability of the edge worker to run in daemon mode. You will also be able to redirect stdout and stderr into their respective log files when running in daemon as well. Added options
--daemon, --log, --stdout, --stderr