-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Pass workload to KE using command args instead of init container #50448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass workload to KE using command args instead of init container #50448
Conversation
|
Thanks! I will take a look later today or tomorrow |
|
I will look at the integration tests. Breeze is being problematic. |
What problems do you have with it? Would love to hear. |
Corporate proxy 😀 |
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach is ok @davidsharp7. Some comments
...cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py
Outdated
Show resolved
Hide resolved
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/pod_generator.py
Outdated
Show resolved
Hide resolved
|
Tests fail |
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/pod_generator.py
Outdated
Show resolved
Hide resolved
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/pod_generator.py
Outdated
Show resolved
Hide resolved
…vidsharp7/airflow into remove_init_container_from_k8
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/pod_generator.py
Outdated
Show resolved
Hide resolved
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, i like how it turned out to be so simple. @davidsharp7 if you can run some dags with these changes, it would give me confidence to approve it.
Are the various tests not enough? Would be happy to do it but my local Mac is spluttering. |
Actually yeah, the CI is running fine with integration tests, so we are good. |
|
@davidsharp7 no further need to rebase, i will merge it once its green. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
|
@davidsharp7 good work on this one! |
closes: #50025
Remove init container and start kubernetes executor via json string.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.