Skip to content

Conversation

@davidsharp7
Copy link
Contributor

closes: #50025

Remove init container and start kubernetes executor via json string.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels May 11, 2025
@jscheffl jscheffl requested a review from amoghrajesh May 11, 2025 12:53
@amoghrajesh
Copy link
Contributor

Thanks! I will take a look later today or tomorrow

@davidsharp7
Copy link
Contributor Author

I will look at the integration tests. Breeze is being problematic.

@potiuk
Copy link
Member

potiuk commented May 11, 2025

I will look at the integration tests. Breeze is being problematic.

What problems do you have with it? Would love to hear.

@davidsharp7
Copy link
Contributor Author

I will look at the integration tests. Breeze is being problematic.

What problems do you have with it? Would love to hear.

Corporate proxy 😀

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach is ok @davidsharp7. Some comments

@davidsharp7 davidsharp7 marked this pull request as ready for review May 13, 2025 05:49
@eladkal
Copy link
Contributor

eladkal commented May 13, 2025

Tests fail

=========================== short test summary info ============================
FAILED tests/kubernetes_tests/test_kubernetes_executor.py::TestKubernetesExecutor::test_integration_run_dag - AssertionError: assert equals failed
  'failed'   'success'
FAILED tests/kubernetes_tests/test_kubernetes_executor.py::TestKubernetesExecutor::test_integration_run_dag_task_mapping - AssertionError: assert equals failed
  'failed'   'success'
FAILED tests/kubernetes_tests/test_kubernetes_executor.py::TestKubernetesExecutor::test_integration_run_dag_with_scheduler_failure - AssertionError: assert equals failed
  'failed'   'success'
======= 3 failed, 47 passed, 3 skipped, 6 warnings in 287.36s (0:04:47) ========

@amoghrajesh amoghrajesh self-requested a review May 14, 2025 07:06
@amoghrajesh amoghrajesh changed the title Remove init container from k8 Pass workload to KE using command args instead of init container May 15, 2025
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, i like how it turned out to be so simple. @davidsharp7 if you can run some dags with these changes, it would give me confidence to approve it.

@davidsharp7
Copy link
Contributor Author

Nice, i like how it turned out to be so simple. @davidsharp7 if you can run some dags with these changes, it would give me confidence to approve it.

Are the various tests not enough? Would be happy to do it but my local Mac is spluttering.

@amoghrajesh
Copy link
Contributor

Nice, i like how it turned out to be so simple. @davidsharp7 if you can run some dags with these changes, it would give me confidence to approve it.

Are the various tests not enough? Would be happy to do it but my local Mac is spluttering.

Actually yeah, the CI is running fine with integration tests, so we are good.

@amoghrajesh
Copy link
Contributor

@davidsharp7 no further need to rebase, i will merge it once its green.

@amoghrajesh amoghrajesh merged commit 967da37 into apache:main May 20, 2025
76 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented May 20, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@amoghrajesh
Copy link
Contributor

@davidsharp7 good work on this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Forced busybox init_container in kubernetes executor after upgrade to v3.

5 participants