Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4246] RBAC Flask-OAuthlib breaks due to dependencies #5045

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

PaulW
Copy link
Contributor

@PaulW PaulW commented Apr 5, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Installing Flask-OAuthlib results in unresolveable dependencies due to updates to the following dependencies:
    oauthlib
    requests-oauthlib

Pinning these versions allows Flask-OAuthlib to work as expected. This has been pinned so including both google_auth and github_enterprise will install the same packages as defined in flask_oauth.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@PaulW PaulW changed the title [AIRFLOW-4246] RBAC Flask-Oauthlib breaks due to dependencies [AIRFLOW-4246] RBAC Flask-OAuthlib breaks due to dependencies Apr 5, 2019
google_auth = ['Flask-OAuthlib>=0.9.1']
flask_oauth = [
'Flask-OAuthlib>=0.9.1',
'oauthlib!=2.0.3,!=2.0.4,!=2.0.5,<3.0.0,>=1.1.2',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My that's quite the version specificiation! Where did it come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've based it on the master branch of the Flask-OAuthlib git repository:

https://github.com/lepture/flask-oauthlib/blob/9e6f152a5bb360e7496210da21561c3e6d41b0e1/setup.py#L44-L47

There were 2 commits to pin these versions:

lepture/flask-oauthlib@bd06c64
lepture/flask-oauthlib@1379c6b

Similar to #5036, we can unpin these once a new release of Flask-OAuthlib is released which includes the above changes.

@ashb ashb merged commit 04ce155 into apache:master Apr 5, 2019
ashb pushed a commit that referenced this pull request Apr 5, 2019
cthenderson pushed a commit to cthenderson/apache-airflow that referenced this pull request Apr 16, 2019
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants