Skip to content

Migrate ElasticsearchSQLHook to use get_df #50454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eladkal merged 2 commits into from
May 11, 2025
Merged

Migrate ElasticsearchSQLHook to use get_df #50454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
656e68a
Migrate `ElasticsearchSQLHook` to use `get_df`
guan404ming May 11, 2025
720835e
Add todo comment
guan404ming May 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/elasticsearch/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Requirements
PIP package Version required
======================================= ==================
``apache-airflow`` ``>=2.10.0``
``apache-airflow-providers-common-sql`` ``>=1.26.0``
``apache-airflow-providers-common-sql`` ``>=1.27.0``
``elasticsearch`` ``>=8.10,<9``
======================================= ==================

Expand Down
2 changes: 1 addition & 1 deletion providers/elasticsearch/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ requires-python = "~=3.9"
# After you modify the dependencies, and rebuild your Breeze CI image with ``breeze ci-image build``
dependencies = [
"apache-airflow>=2.10.0",
"apache-airflow-providers-common-sql>=1.26.0",
"apache-airflow-providers-common-sql>=1.27.0",
"elasticsearch>=8.10,<9",
]

Expand Down
11 changes: 11 additions & 0 deletions providers/elasticsearch/src/airflow/providers/elasticsearch/hooks/elasticsearch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,17 @@ def get_uri(self) -> str:

return uri

def _get_polars_df(
self,
sql,
parameters: list | tuple | Mapping[str, Any] | None = None,
**kwargs,
):
# TODO: Custom ElasticsearchSQLCursor is incompatible with polars.read_database.
# To support: either adapt cursor to polars._executor interface or create custom polars reader.
# https://github.com/apache/airflow/pull/50454
raise NotImplementedError("Polars is not supported for Elasticsearch")


class ElasticsearchPythonHook(BaseHook):
"""
Expand Down
4 changes: 4 additions & 0 deletions providers/elasticsearch/tests/unit/elasticsearch/hooks/test_elasticsearch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,10 @@ def test_get_df_pandas(self):
self.spy_agency.assert_spy_called(self.cur.close)
self.spy_agency.assert_spy_called(self.cur.execute)

def test_get_df_polars(self):
with pytest.raises(NotImplementedError):
self.db_hook.get_df("SQL", df_type="polars")

def test_run(self):
statement = "SELECT * FROM hollywood.actors"

Expand Down