Change CohereHook.get_conn type from property to method in the next major apache-airflow-providers-cohere #50470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjyangkevin
force-pushed
the
issues/38350/cohere-hook-updates
branch
from
2df4253 to
0ba49e4
Compare
1 task
eladkal
approved these changes
May 12, 2025
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I want to raise this PR to resolve the issue #38350
Closes: #38350
The main changes include
@cached_propertydecoratedget_conn(self)to a regular method.self._clientto store the client instance. If the attribute is already initialized to a client instance, this instance will be reused.get_connattribute are also refactored to useget_conn()method.All the test cases related to the Cohere providers are checked and updated correspondingly. Unit tests are run successfully.
Thank you for your time to review in advance, and I would appreciate any feedback, and let me know if there is any potential change needed for the PR.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.