Skip to content

Conversation

@vincbeck
Copy link
Contributor

Resolves #50187.

I vendored in Flask-appbuilder code needed by comparing flask-appbuilder 4.5.3 and 4.6.3.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@vincbeck vincbeck force-pushed the vincbeck/fab-upgrade branch 4 times, most recently from ab3b034 to 7becd6d Compare May 13, 2025 14:56
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do I understand correctly, that we are adding the models but NOT running the migration for FAB and not creating the models - and we are not using the "Groups" feature at all ?

Or they will be created automatically somehow?

@vincbeck
Copy link
Contributor Author

vincbeck commented May 13, 2025

Looks good. Do I understand correctly, that we are adding the models but NOT running the migration for FAB and not creating the models - and we are not using the "Groups" feature at all ?

Or they will be created automatically somehow?

You are correct, we are not using the groups feature. Though, I updated the models using new tables such as ab_user_group and ab_group without running any migration and everything works fine. When I looked at my DB, these tables exist. I am not sure when they have been created but I am sure I have not modified/created any migration

@vincbeck vincbeck force-pushed the vincbeck/fab-upgrade branch from 7becd6d to c6aaa8c Compare May 13, 2025 15:57
@potiuk
Copy link
Member

potiuk commented May 13, 2025

You are correct, we are not using the groups feature. Though, I updated the models using new tables such as ab_user_group and ab_group without running any migration and everything works fine. When I looked at my DB, these tables exist. I am not sure when they have been created but I am sure I have not modified/created any migration

Hmm.. Maybe Fab auto-migrates the models ?

@vincbeck
Copy link
Contributor Author

You are correct, we are not using the groups feature. Though, I updated the models using new tables such as ab_user_group and ab_group without running any migration and everything works fine. When I looked at my DB, these tables exist. I am not sure when they have been created but I am sure I have not modified/created any migration

Hmm.. Maybe Fab auto-migrates the models ?

Maybe

@vincbeck
Copy link
Contributor Author

vincbeck commented May 13, 2025

You are correct, we are not using the groups feature. Though, I updated the models using new tables such as ab_user_group and ab_group without running any migration and everything works fine. When I looked at my DB, these tables exist. I am not sure when they have been created but I am sure I have not modified/created any migration

Hmm.. Maybe Fab auto-migrates the models ?

Maybe

But on the other end it makes sense, we do not have migration defining FAB related tables. FAB handles it itself. When you reset the DB, the tables are automatically created even though we do not have migration for it. Same thing applies here with the new tables

@vincbeck vincbeck merged commit e6430c2 into apache:main May 13, 2025
65 checks passed
@vincbeck vincbeck deleted the vincbeck/fab-upgrade branch May 13, 2025 16:35
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
kaxil pushed a commit that referenced this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to FAB 4.6.2 in FAB provider

2 participants