Fix aws_conn_id defaulting after dag.test was updated to use TaskSDK. #50515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
ferruzzi
force-pushed
the
ferruzzi/fix-connection-failures
branch
from
4ad16f4 to
aed58c4
Compare
eladkal
reviewed
May 13, 2025
providers/amazon/src/airflow/providers/amazon/aws/hooks/base_aws.py
Outdated
Show resolved
Hide resolved
ferruzzi
force-pushed
the
ferruzzi/fix-connection-failures
branch
from
aed58c4 to
3779cee
Compare
vincbeck
reviewed
May 13, 2025
providers/amazon/src/airflow/providers/amazon/aws/hooks/base_aws.py
Outdated
Show resolved
Hide resolved
vincbeck
approved these changes
May 21, 2025
dadonnelly316
pushed a commit
to dadonnelly316/airflow
that referenced
this pull request
May 26, 2025
…apache#50515) * Fix aws_conn_id defaulting after dag,test was updated to use TaskSDK. * put api import behind a version check * put exception type check behind a version check * mypy gets confused on the type hinting with the ternary assignment
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
…apache#50515) * Fix aws_conn_id defaulting after dag,test was updated to use TaskSDK. * put api import behind a version check * put exception type check behind a version check * mypy gets confused on the type hinting with the ternary assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Task API raises an AirflowRuntimeError which we need to catch now as well. In an effort to not accidentally swallow any other RuntimeErrors that may pop up, I added a message match on it and re-raise if it doesn't have the expected "connection not found" message.
Related slack discussion: https://apache-airflow.slack.com/archives/C06K9Q5G2UA/p1746835026272909?thread_ts=1746819752.521919&cid=C06K9Q5G2UA
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.