-
Notifications
You must be signed in to change notification settings - Fork 16.4k
feat: add create_collection function to MongoHook #50518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
potiuk
merged 11 commits into
apache:main
from
nailo2c:feature/add-create_collection-to-MongoHook
May 22, 2025
Merged
feat: add create_collection function to MongoHook #50518
potiuk
merged 11 commits into
apache:main
from
nailo2c:feature/add-create_collection-to-MongoHook
May 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
381326d to
1a5a9e0
Compare
1a5a9e0 to
91fa706
Compare
Member
|
Closed / reopened to rebuild after rebase to see if static check still fails |
Lee-W
reviewed
May 19, 2025
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
nailo2c
commented
May 19, 2025
Lee-W
approved these changes
May 20, 2025
potiuk
approved these changes
May 22, 2025
dadonnelly316
pushed a commit
to dadonnelly316/airflow
that referenced
this pull request
May 26, 2025
* feat: add create_collection function with unit tests * rm comments * fix static checks * make the type of `create_kwargs` clearer Co-authored-by: Wei Lee <weilee.rx@gmail.com> * modfiy variable name: create_if_exists -> return_if_exists * move import CollectionInvalid to top --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* feat: add create_collection function with unit tests * rm comments * fix static checks * make the type of `create_kwargs` clearer Co-authored-by: Wei Lee <weilee.rx@gmail.com> * modfiy variable name: create_if_exists -> return_if_exists * move import CollectionInvalid to top --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #33076
This PR adds a
create_collection()function to theMongoHookwhich refers to pymongo.database.Database.create_collection.Before:
After:
I’ve completed an end-to-end test on my local Airflow instance, and everything worked as expected.
