Fix default_args application in operator partial #50525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
approved these changes
May 13, 2025
eladkal
added
type:bug-fix
kaxil
approved these changes
May 13, 2025
ghost
reviewed
May 13, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 14, 2025
(cherry picked from commit 7d6a18a) Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
May 14, 2025
uranusjr
added a commit
that referenced
this pull request
May 14, 2025
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partialdoes not apply most dag- and task-group-level default arguments; only those needed by the scheduler (it doesn’t know exactly, so all BaseOperator args are loaded in to be safe).Most other default arguments, meaningful only when the task is run, are only applied when the task is unmapped. This is done in BaseOperatorMeta, logic shared with regular tasks.
This is only a problem in 3.0 because the task sdk rewrote
partial’s argument signature; now most arguments are just passed in**kwargs, and thuspartiallost its introspection logic, implemented using its own argument list in 2.x.Fix #50389.