docs: conditionally render section‐move links in sections‐and‐options include #50582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
reviewed
May 14, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Sounds like a decent fix, lets wait for CI
sunank200
changed the title
Contributor
|
I merge this one quickly in hope this fix the issue as I have to unblock providers release |
eladkal
approved these changes
May 14, 2025
Member
|
Nice |
Contributor
|
Thanks @sunank200 |
Member
|
Should this be backported to |
pierrejeambrun
pushed a commit
to astronomer/airflow
that referenced
this pull request
May 14, 2025
… include (apache#50582) * Add condition for section move in docs * docs(fab): add Sphinx anchors for access_denied_message and expose_hostname config options (cherry picked from commit 39f215f)
pierrejeambrun
added a commit
that referenced
this pull request
May 14, 2025
… (#50544) * Move access_denied_message webserver config to fab (#50208) * Move access_denied_message webserver config to fab * Fix CI * Update to fab 2.0.3 * Change core to 3.0.2 * fab depends on apache-airflow 3.0.2 * Fix CI (cherry picked from commit a18a1df) * Fix CI * docs: conditionally render section‐move links in sections‐and‐options include (#50582) * Add condition for section move in docs * docs(fab): add Sphinx anchors for access_denied_message and expose_hostname config options (cherry picked from commit 39f215f) --------- Co-authored-by: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com>
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
… (#50544) * Move access_denied_message webserver config to fab (#50208) * Move access_denied_message webserver config to fab * Fix CI * Update to fab 2.0.3 * Change core to 3.0.2 * fab depends on apache-airflow 3.0.2 * Fix CI (cherry picked from commit a18a1df) * Fix CI * docs: conditionally render section‐move links in sections‐and‐options include (#50582) * Add condition for section move in docs * docs(fab): add Sphinx anchors for access_denied_message and expose_hostname config options (cherry picked from commit 39f215f) --------- Co-authored-by: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com>
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
… include (apache#50582) * Add condition for section move in docs * docs(fab): add Sphinx anchors for access_denied_message and expose_hostname config options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is breaking the docs in main with following error:
I’ve updated the Jinja include for the core configuration reference so that it only emits a
Sphinx :ref:link when the target section is part of the core docs. For provider‐only options (the new fab ones), it now falls back to plain text rather than linking to an undefinedconfig:fablabel. This removes the“undefined label”warnings forfab__access_denied_messageandfab__expose_hostname.As part of PR we missed adding Sphinx anchors for
access_denied_messageandexpose_hostnameconfig options:Also added two new Sphinx reference labels in
providers/fab/docs/configurations-ref.rst:config:fab__access_denied_messageconfig:fab__expose_hostname^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.