Skip to content

Conversation

@gopidesupavan
Copy link
Member

When connection id is set in remote logging config, its not required to set these args, the first lookup we are doing with connectionid.

https://github.com/gopidesupavan/airflow/blob/bc3b4ec6a67a63fd464e93d76807cd9a5dadaa7d/providers/google/src/airflow/providers/google/cloud/log/gcs_task_handler.py#L92


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:logging area:providers provider:google Google (including GCP) related issues labels May 14, 2025
@gopidesupavan gopidesupavan requested a review from ashb May 14, 2025 09:08
@gopidesupavan
Copy link
Member Author

This avoids setting empty dict to remote_task_handler_kwargs otherwise the initialisation will fail

https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1746579821817069?thread_ts=1745522030.825469&cid=CCQ7EGB1P

@gopidesupavan
Copy link
Member Author

Tested changes works fine:

image

@gopidesupavan
Copy link
Member Author

cc: @eladkal would it be possible to add this in the next wave?

@amoghrajesh
Copy link
Contributor

@gopidesupavan does this fix the remote logging issue?

@gopidesupavan
Copy link
Member Author

@gopidesupavan does this fix the remote logging issue?

With LocalExecutor remote logging not working, not sure need to drill down :)

When i testing this gcs issue, i got the above issue.

With Celery executor its working fine, no errors. this PR change tested with celery executor.

@gopidesupavan gopidesupavan merged commit 80960a1 into apache:main May 14, 2025
71 checks passed
@gopidesupavan gopidesupavan deleted the make-gcp-remote-logs-args-optional branch May 14, 2025 11:16
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
@ashb ashb mentioned this pull request Jun 16, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:logging area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants