fix: Use source hook instead of destination hook when reading records in non-paginated mode in GenericTransfer #50598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugraoz93
approved these changes
May 14, 2025
Contributor
bugraoz93
left a comment
bugraoz93
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the PR!
eladkal
approved these changes
May 22, 2025
eladkal
force-pushed
the
fix/use-wrong-hook-generic-transfer
branch
from
a02fbd2 to
36deb6d
Compare
eladkal
force-pushed
the
fix/use-wrong-hook-generic-transfer
branch
from
36deb6d to
48af548
Compare
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
… in non-paginated mode in GenericTransfer (apache#50598) * fix: Use source hook when reading records in non-paginated mode in GenericTransfer * refactor: Moved mocked hooks as class variable in test GenericTransfer --------- Co-authored-by: David Blain <david.blain@infrabel.be>
jose-lehmkuhl
pushed a commit
to jose-lehmkuhl/airflow
that referenced
this pull request
Jul 11, 2025
… in non-paginated mode in GenericTransfer (apache#50598) * fix: Use source hook when reading records in non-paginated mode in GenericTransfer * refactor: Moved mocked hooks as class variable in test GenericTransfer --------- Co-authored-by: David Blain <david.blain@infrabel.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #49731 reported by @Baptistouille
replaces: #49783
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.