[v3-0-test] Fix permission check on the ui config endpoint (#50564) #50619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just config for the UI, not the whole Airflow instances config, which is what the config permission for users controls. If the user doesn't have the config permission, without this change, the user cannot use the UI at all. So, instead we just check that the user is authenticated at all. (cherry picked from commit 0dad2bb) Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
jedcunningham
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun and
rawwar
as code owners
pierrejeambrun
approved these changes
May 15, 2025
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
…50619) This is just config for the UI, not the whole Airflow instances config, which is what the config permission for users controls. If the user doesn't have the config permission, without this change, the user cannot use the UI at all. So, instead we just check that the user is authenticated at all. (cherry picked from commit 0dad2bb) Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just config for the UI, not the whole Airflow instances config,
which is what the config permission for users controls. If the user
doesn't have the config permission, without this change, the user cannot
use the UI at all.
So, instead we just check that the user is authenticated at all.
(cherry picked from commit 0dad2bb)
Co-authored-by: Jed Cunningham 66968678+jedcunningham@users.noreply.github.com
Co-authored-by: LIU ZHE YOU 68415893+jason810496@users.noreply.github.com