AIP-38: Add support for owner_links in DAG Header UI #50627
Conversation
choo121600
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
choo121600
changed the title
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Thanks for the PR 🎉
A few suggestions
|
Can you provide a screenshot of a Dag with multiple owners too? I think we will need the same comma separation and "+ X more" component that we use for Tags |
Would it make sense to reuse the |
Yes and yes |
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Overall LGTM, just one comment
* feat: Add owner_links field to DAGDetailsResponse model and update related schemas * feat: add owner_links to DAG Header owner section * remove owner_links in test code * add tests for DAG owner_links in DAG details endpoint * refactor: apply ruff formatting to test_dags.py * refactor: simplify DagOwners component * refactor: improve separator logic in DagOwners component * refactor: apply LimitedItemsList for cleaner item rendering logic * refactor: enhance Link component attributes
* feat: Add owner_links field to DAGDetailsResponse model and update related schemas * feat: add owner_links to DAG Header owner section * remove owner_links in test code * add tests for DAG owner_links in DAG details endpoint * refactor: apply ruff formatting to test_dags.py * refactor: simplify DagOwners component * refactor: improve separator logic in DagOwners component * refactor: apply LimitedItemsList for cleaner item rendering logic * refactor: enhance Link component attributes
3 participants
This PR integrates the owner_links metadata into the DAG Header UI component. #48562
Screen.Recording.2025-05-15.at.10.09.56.AM.mov
Screen.Recording.2025-05-16.at.11.05.38.AM.mov
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.