Fix broken cncf.kubernetes for Airflow 2 #50651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
potiuk
force-pushed
the
revert-rendering-method-for-k8s-template
branch
from
751ad02 to
0414f0a
Compare
Member
|
This mix of core and provider side code for k8s is painful haha. |
jedcunningham
approved these changes
May 15, 2025
The apache#50650 broke cncf.kubernetes for Airflow 2 - it removed a method that was not used in Airflow 3 but it turns out that those methods were also used in Airflow 2. We revert the change but also we add skipif for Airflow 3 to skip the test on Airflow 3 and to mark it essentially for removal when we drop compatibility with Airflow 2. Revert "Remove unused db method in k8s provider (apache#49186)" This reverts commit 0ca0f17.
potiuk
force-pushed
the
revert-rendering-method-for-k8s-template
branch
from
75fd11c to
6ce720e
Compare
ayush3singh
pushed a commit
to ayush3singh/airflow
that referenced
this pull request
May 17, 2025
The apache#50650 broke cncf.kubernetes for Airflow 2 - it removed a method that was not used in Airflow 3 but it turns out that those methods were also used in Airflow 2. We revert the change but also we add skipif for Airflow 3 to skip the test on Airflow 3 and to mark it essentially for removal when we drop compatibility with Airflow 2. Revert "Remove unused db method in k8s provider (apache#49186)" This reverts commit 0ca0f17.
ayush3singh
pushed a commit
to ayush3singh/airflow
that referenced
this pull request
May 17, 2025
The apache#50650 broke cncf.kubernetes for Airflow 2 - it removed a method that was not used in Airflow 3 but it turns out that those methods were also used in Airflow 2. We revert the change but also we add skipif for Airflow 3 to skip the test on Airflow 3 and to mark it essentially for removal when we drop compatibility with Airflow 2. Revert "Remove unused db method in k8s provider (apache#49186)" This reverts commit 0ca0f17.
15 tasks
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
The apache#50650 broke cncf.kubernetes for Airflow 2 - it removed a method that was not used in Airflow 3 but it turns out that those methods were also used in Airflow 2. We revert the change but also we add skipif for Airflow 3 to skip the test on Airflow 3 and to mark it essentially for removal when we drop compatibility with Airflow 2. Revert "Remove unused db method in k8s provider (apache#49186)" This reverts commit 0ca0f17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #50650 broke cncf.kubernetes for Airflow 2 - it removed a method that was not used in Airflow 3 but it turns out that those methods were also used in Airflow 2. We revert the change but also we add skipif for Airflow 3 to skip the test on Airflow 3 and to mark it essentially for removal when we drop compatibility with Airflow 2.
Revert "Remove unused db method in k8s provider (#49186)"
This reverts commit 0ca0f17.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.