Update useTableURLState hook for sticky table sort
#50720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guan404ming
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
guan404ming
changed the title
useTableURLState hook for sticky table sort
shubhamraj-git
approved these changes
May 18, 2025
Member
Author
|
Thanks! |
bbovenzi
approved these changes
May 20, 2025
bbovenzi
added
the
backport-to-v3-1-test
github-actions bot
pushed a commit
that referenced
this pull request
May 20, 2025
(cherry picked from commit 06278ce) Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
May 20, 2025
Member
Author
|
Thanks! |
pierrejeambrun
pushed a commit
that referenced
this pull request
May 21, 2025
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
May 21, 2025
dadonnelly316
pushed a commit
to dadonnelly316/airflow
that referenced
this pull request
May 26, 2025
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR
as a following PR for #50600
cc: @bbovenzi @pierrejeambrun
Why
since different people may want different sort order in the same instance. Make the sort be sticky would rather a good choice than be a global config
How
Update
useTableURLStateto store the sort into localStorage for pages using the table and use it as a default value. This solution could not only support for dag list pages but for all pages with sortable table.local storage may look like
current ui
Screen.Recording.2025-05-17.at.4.34.36.PM.mov
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.