Refactor Edge Worker CLI for smaller module #50738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:edge
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Edge Worker CLI by extracting the previously monolithic _EdgeWorkerCli into a dedicated module and renaming it to EdgeWorker. It also extracts basic signalling functionality into its own module with accompanying tests.
- Refactored Edge Worker CLI class into a separate module and renamed it.
- Updated tests to import and use the new EdgeWorker class.
- Introduced a new signalling module with functions for managing PID files.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| providers/edge3/tests/unit/edge3/worker_api/routes/test_worker.py | Updated import and fixture type hint to use EdgeWorker instead of _EdgeWorkerCli. |
| providers/edge3/tests/unit/edge3/cli/test_signalling.py | Added tests for the new signalling functionality ensuring PID file behavior is as expected. |
| providers/edge3/src/airflow/providers/edge3/cli/signalling.py | New module handling PID file management and signalling for edge workers. |
shubhamraj-git
approved these changes
May 18, 2025
Contributor
shubhamraj-git
left a comment
shubhamraj-git
left a comment
There was a problem hiding this comment.
Thanks for the refactor.
Looks good.
dadonnelly316
pushed a commit
to dadonnelly316/airflow
that referenced
this pull request
May 26, 2025
* Refactor Edge Worker CLI for smaller module * Ups, delete un-needed redundant test module * Add a test for command --------- Co-authored-by: Shubham Raj <48172486+shubhamraj-git@users.noreply.github.com>
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* Refactor Edge Worker CLI for smaller module * Ups, delete un-needed redundant test module * Add a test for command --------- Co-authored-by: Shubham Raj <48172486+shubhamraj-git@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pure re-factoring PR. The python module providers/edge3/src/airflow/providers/edge3/cli/edge_command.py was just too large.
I splitted the class
_EdgeWorkerCliout into a separate module and renamed it toEdgeWorker. Also extracted some basics for signalling.Should be zero functional change, even if it looks like a large review. Just pushing and changing a lot of names.