-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix incorrect reference to SimpleHttpOperator in 3.0.0 release notes #50740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect reference to SimpleHttpOperator in 3.0.0 release notes #50740
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
I just ran the pre-commits locally and generated a reproducible_build.yaml. I will commit it after I validate that the error I'm now getting on the "Check top-level breeze deps" check is due to a misconfiguration in my local environment |
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most likely you did a bad rebase, can you fix the branch so the PR only contains the relevant change.
Thanks
|
sounds good - I will fix the branch |
|
@dadonnelly316 can you fix the doc entry and resolve conflicts + rebase? |
|
yes working on this now |
bd4bca0 to
5b86c65
Compare
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 71f4224 v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
|
Raised #53661 for backport to v3-0-test |
|
@eladkal - Why did the auto-backport fail? I'd like to be aware should I contribute again in the future |
Because ut generated conflicts - we have certain pre-commits that are run in certain situations. Or sometimes the branches diverged too much and same files changed in both branches differently - or there were some previous changes that also changed that file and they have not been backported. There are many reasons why "auto" backport can fail and if this happens - the bot will give exact instructions what you should do - including step "resolve all conflicts". This is somewhat often when you cherry-pick stuf - that you should resolve conflicts manually - especially when the branches diverge by a few hundreds or few thousands commits (which is the case now). |
Those instructions are pretty clear I think (as long as you read them of course). |
This PR removes an invalid reference to SimpleHttpOperator in the 3.0.0 release notes under the Provider Refactor & Standardization section. SimpleHttpOperator was not moved from airflow core to apache-airflow-providers-standard. It was under the http provider and removed in airflow 3.0.0 in place of the HttpOperator.
closes: #50712
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.