Skip empty dag run conf rows and set statement timeout #50788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:db-migrations
dstandish
force-pushed
the
skip-empty-dag-run-conf-rows-and-set-statement-timeout
branch
from
e8eb093 to
5d34e0f
Compare
...low-core/src/airflow/migrations/versions/0055_3_0_0_remove_pickled_data_from_dagrun_table.py
Show resolved
Hide resolved
...low-core/src/airflow/migrations/versions/0055_3_0_0_remove_pickled_data_from_dagrun_table.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/migrations/versions/0049_3_0_0_remove_pickled_data_from_xcom_table.py
Show resolved
Hide resolved
Contributor
ephraimbuddy
left a comment
ephraimbuddy
left a comment
There was a problem hiding this comment.
Should we create a new migration file instead of updating already released migrations? For new release, it would appear as if there's no migration on the version, and upgrading from a previous one like 3.0.1 won't run the migration.
Contributor
Author
I don't think so -- we're just optimizing the existing migrations. We've done this many times before. If a user is on 3.0.1, they've already passed the problematic migrations. So it remains true that there is no migration between 3.0.1 and 3.0.2. |
dstandish
added
the
backport-to-v3-1-test
phanikumv
force-pushed
the
skip-empty-dag-run-conf-rows-and-set-statement-timeout
branch
from
89fd264 to
a6e6afb
Compare
jedcunningham
approved these changes
May 27, 2025
Also, set the statement timeout a little higher for xcom migration.
…_pickled_data_from_xcom_table.py Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
dstandish
force-pushed
the
skip-empty-dag-run-conf-rows-and-set-statement-timeout
branch
from
a6e6afb to
6b6f3a7
Compare
dstandish
deleted the
skip-empty-dag-run-conf-rows-and-set-statement-timeout
branch
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker f75b607 v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
Don't bother depickling `{}` object in dag run conf
Also, set the statement timeout a little higher for xcom migration.
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
jose-lehmkuhl
pushed a commit
to jose-lehmkuhl/airflow
that referenced
this pull request
Jul 11, 2025
Don't bother depickling `{}` object in dag run conf
Also, set the statement timeout a little higher for xcom migration.
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
dstandish
added a commit
to astronomer/airflow
that referenced
this pull request
Jul 22, 2025
Don't bother depickling `{}` object in dag run conf
Also, set the statement timeout a little higher for xcom migration.
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
(cherry picked from commit f75b607)
dstandish
added a commit
to astronomer/airflow
that referenced
this pull request
Jul 22, 2025
…pache#50788) Don't bother depickling `{}` object in dag run conf Also, set the statement timeout a little higher for xcom migration. Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> (cherry picked from commit f75b607)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't bother depickling
{}object in dag run confAlso, set the statement timeout a little higher for xcom migration.