Fix KubernetesPodOperator AutomountServiceAccountToken from Pod Template #50800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DjVinnii
requested review from
ashb,
gopidesupavan,
hussein-awala,
jason810496,
jedcunningham and
potiuk
as code owners
boring-cyborg
bot
added
area:kubernetes-tests
area:providers
provider:cncf-kubernetes
eladkal
approved these changes
May 20, 2025
Contributor
|
Static checks are failing |
eladkal
reviewed
May 20, 2025
providers/cncf/kubernetes/tests/unit/cncf/kubernetes/operators/test_pod.py
Outdated
Show resolved
Hide resolved
eladkal
force-pushed
the
KPO-automountServiceAccountToken
branch
from
531919f to
57a8c91
Compare
15 tasks
dadonnelly316
pushed a commit
to dadonnelly316/airflow
that referenced
this pull request
May 26, 2025
…ate (apache#50800) * Set default to None * Update tests * Check for None values instead Falsy values * Fix tests * fix static checks --------- Co-authored-by: Vincent Kling <vincent.kling@stedin.net> Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
…ate (apache#50800) * Set default to None * Update tests * Check for None values instead Falsy values * Fix tests * fix static checks --------- Co-authored-by: Vincent Kling <vincent.kling@stedin.net> Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to None for the automounting of the Service Account Token to keep the behavior as close to the Kubernetes default behavior. Also make sure that the
merge_objects()function in the Pod Generator does not default to the client value (None in this case) when the base value is explicitly falsy. This was causing issues if apod_template_filewas provided where value ofautomountServiceAccountwas set to false.related: #50599 (comment)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.