Skip to content

[v3-0-test] make dag_run conf nullable in Details page (#50719) #50817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
May 21, 2025
Merged

[v3-0-test] make dag_run conf nullable in Details page (#50719) #50817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow-core/src/airflow/api_fastapi/core_api/datamodels/dag_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class DAGRunResponse(BaseModel):
run_type: DagRunType
state: DagRunState
triggered_by: DagRunTriggeredByType | None
conf: dict
conf: dict | None
note: str | None
dag_versions: list[DagVersionResponse]
bundle_version: str | None
Expand Down
6 changes: 4 additions & 2 deletions airflow-core/src/airflow/api_fastapi/core_api/openapi/_private_ui.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,8 +934,10 @@ components:
- $ref: '#/components/schemas/DagRunTriggeredByType'
- type: 'null'
conf:
additionalProperties: true
type: object
anyOf:
- additionalProperties: true
type: object
- type: 'null'
title: Conf
note:
anyOf:
Expand Down
6 changes: 4 additions & 2 deletions airflow-core/src/airflow/api_fastapi/core_api/openapi/v1-rest-api-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8231,8 +8231,10 @@ components:
- $ref: '#/components/schemas/DagRunTriggeredByType'
- type: 'null'
conf:
additionalProperties: true
type: object
anyOf:
- additionalProperties: true
type: object
- type: 'null'
title: Conf
note:
anyOf:
Expand Down
11 changes: 9 additions & 2 deletions airflow-core/src/airflow/ui/openapi-gen/requests/schemas.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2247,8 +2247,15 @@ export const $DAGRunResponse = {
],
},
conf: {
additionalProperties: true,
type: "object",
anyOf: [
{
additionalProperties: true,
type: "object",
},
{
type: "null",
},
],
title: "Conf",
},
note: {
Expand Down
2 changes: 1 addition & 1 deletion airflow-core/src/airflow/ui/openapi-gen/requests/types.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ export type DAGRunResponse = {
triggered_by: DagRunTriggeredByType | null;
conf: {
[key: string]: unknown;
};
} | null;
note: string | null;
dag_versions: Array<DagVersionResponse>;
bundle_version: string | null;
Expand Down
2 changes: 1 addition & 1 deletion airflow-core/src/airflow/ui/src/pages/Run/Details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export const Details = () => {
<Table.Row>
<Table.Cell>Run Config</Table.Cell>
<Table.Cell>
<RenderedJsonField content={dagRun.conf} />
<RenderedJsonField content={dagRun.conf ?? {}} />
</Table.Cell>
</Table.Row>
</Table.Body>
Expand Down
2 changes: 1 addition & 1 deletion airflow-ctl/src/airflowctl/api/datamodels/generated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1219,7 +1219,7 @@ class DAGRunResponse(BaseModel):
run_type: DagRunType
state: DagRunState
triggered_by: DagRunTriggeredByType | None = None
conf: Annotated[dict[str, Any], Field(title="Conf")]
conf: Annotated[dict[str, Any] | None, Field(title="Conf")] = None
note: Annotated[str | None, Field(title="Note")] = None
dag_versions: Annotated[list[DagVersionResponse], Field(title="Dag Versions")]
bundle_version: Annotated[str | None, Field(title="Bundle Version")] = None
Expand Down