[v3-0-test] Fix 404 log error for non-latest task tries in multi-host worker environments #50833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason810496
requested review from
bugraoz93,
ephraimbuddy,
pierrejeambrun and
rawwar
as code owners
pierrejeambrun
approved these changes
May 20, 2025
bugraoz93
approved these changes
May 20, 2025
…rker environments (apache#50175) * fix: resolve 404 log error for non-latest task tries in multi-host worker environments * refactor: extract TaskInstance and TaskInstanceHistory query logic from `get_log` endpoint function * test: add unit test for `get_task_instance_or_history_for_try_number` function * fix: resolve sqlite lock error apache#50763 Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com> --------- Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com> (cherry picked from commit 0b0ff5d)
potiuk
force-pushed
the
backport-0b0ff5d-v3-0-test
branch
from
a5d54a3 to
f52a769
Compare
potiuk
approved these changes
May 21, 2025
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
…rker environments (#50175) (#50833) * fix: resolve 404 log error for non-latest task tries in multi-host worker environments * refactor: extract TaskInstance and TaskInstanceHistory query logic from `get_log` endpoint function * test: add unit test for `get_task_instance_or_history_for_try_number` function * fix: resolve sqlite lock error #50763 --------- (cherry picked from commit 0b0ff5d) Co-authored-by: oboki <oboki@kakao.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #50175
What
Backport #50175 to
v3-10-testdue to router conflicts requiring manual resolution.