Skip to content

API handle slashes in variable keys #50841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pierrejeambrun merged 2 commits into from
May 21, 2025
Merged

API handle slashes in variable keys #50841

pierrejeambrun merged 2 commits into from
May 21, 2025

Conversation

@pierrejeambrun
Copy link
Member

@pierrejeambrun pierrejeambrun commented May 20, 2025

closes: #50796

@pierrejeambrun pierrejeambrun added this to the Airflow 3.0.2 milestone May 20, 2025
@pierrejeambrun pierrejeambrun self-assigned this May 20, 2025
@pierrejeambrun pierrejeambrun added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label May 20, 2025
@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label May 20, 2025
@pierrejeambrun pierrejeambrun mentioned this pull request May 20, 2025
Closed
2 tasks
shubhamraj-git
shubhamraj-git approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@shubhamraj-git shubhamraj-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

jason810496
jason810496 approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks !

@pierrejeambrun
Copy link
Member Author

pierrejeambrun commented May 21, 2025

Unrelated CI failure, merging

@pierrejeambrun pierrejeambrun merged commit 3e4104b into apache:main May 21, 2025
93 of 94 checks passed
@pierrejeambrun pierrejeambrun deleted the 50796-handle-slashes-in-variable-keys branch May 21, 2025 09:31
github-actions bot pushed a commit that referenced this pull request May 21, 2025
@pierrejeambrun @vatsrahul1001
[v3-0-test] API handle slashes in variable keys (#50841)
c9d3912 
(cherry picked from commit 3e4104b)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented May 21, 2025

Backport successfully created: v3-0-test

Status Branch Result
✅ v3-0-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 21, 2025
@pierrejeambrun @vatsrahul1001
[v3-0-test] API handle slashes in variable keys (apache#50841)
f2057f1 
(cherry picked from commit 3e4104b)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
potiuk pushed a commit that referenced this pull request May 21, 2025
@pierrejeambrun @vatsrahul1001 @potiuk
[v3-0-test] API handle slashes in variable keys (#50841)
946c004 
(cherry picked from commit 3e4104b)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request May 21, 2025
@pierrejeambrun @vatsrahul1001 @nailo2c
API handle slashes in variable keys (apache#50841)
bf634e0 
Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
potiuk pushed a commit that referenced this pull request May 22, 2025
@pierrejeambrun @vatsrahul1001 @potiuk
[v3-0-test] API handle slashes in variable keys (#50841)
a45f9d5 
(cherry picked from commit 3e4104b)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
pierrejeambrun added a commit that referenced this pull request May 22, 2025
@github-actions @pierrejeambrun @vatsrahul1001
[v3-0-test] API handle slashes in variable keys (#50841) (#50874)
6d7bfd0 
(cherry picked from commit 3e4104b)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
dadonnelly316 pushed a commit to dadonnelly316/airflow that referenced this pull request May 26, 2025
@pierrejeambrun @vatsrahul1001 @dadonnelly316
API handle slashes in variable keys (apache#50841)
7770b13 
Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
kaxil pushed a commit that referenced this pull request Jun 3, 2025
@github-actions @pierrejeambrun
@vatsrahul1001 @kaxil
[v3-0-test] API handle slashes in variable keys (#50841) (#50874)
86296fd 
(cherry picked from commit 3e4104b)

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
@pierrejeambrun @vatsrahul1001 @sanederchik
API handle slashes in variable keys (apache#50841)
4303741 
Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bugraoz93 bugraoz93 bugraoz93 approved these changes

@vatsrahul1001 vatsrahul1001 vatsrahul1001 approved these changes

@shubhamraj-git shubhamraj-git shubhamraj-git approved these changes

@jason810496 jason810496 jason810496 approved these changes

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@rawwar rawwar Awaiting requested review from rawwar rawwar is a code owner

+1 more reviewer

@aritra24 aritra24 aritra24 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pierrejeambrun pierrejeambrun

Labels

area:API Airflow's REST/HTTP API backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Milestone

Airflow 3.0.2

Development

Successfully merging this pull request may close these issues.

Cannot get/patch/delete a variable if its key contains slash character

6 participants

@pierrejeambrun @bugraoz93 @aritra24 @vatsrahul1001 @shubhamraj-git @jason810496