Skip to content

Merging TimeSensorAsync with TimeSensor #50864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kaxil merged 6 commits into from
May 23, 2025
Merged

Merging TimeSensorAsync with TimeSensor #50864

kaxil merged 6 commits into from
May 23, 2025

Conversation

@jroachgolf84
Copy link
Collaborator

@jroachgolf84 jroachgolf84 commented May 20, 2025 •
edited
Loading

Per #50812, merging the TimeSensorAsync Sensor with TimeSensor, and adding deferrable mode.

@jroachgolf84
Copy link
Collaborator Author

jroachgolf84 commented May 21, 2025 •
edited
Loading

@eladkal, what do we want to do here with this one failing test? This is for a TimeDeltaSensorAsync test, which I believe is going to be refactored in a similar way to this (per #50811). Otherwise, this is ready for review.

EDIT: This test was not altered in any way by my logic.

@eladkal eladkal requested review from Lee-W and gopidesupavan May 21, 2025 05:29
Lee-W
Lee-W reviewed May 21, 2025
View reviewed changes
Lee-W
Lee-W reviewed May 21, 2025
View reviewed changes
eladkal
eladkal reviewed May 21, 2025
View reviewed changes
@jroachgolf84 @kaxil
Stashing initial changes
af4a05d
@jroachgolf84 @kaxil
Merging TimeSensorAsync to TimeSensor with deferrable mode
7ac555b 
Per apache#50812, merging the `TimeSensorAsync` Sensor with `TimeSensor`, and adding deferrable mode.
@kaxil kaxil requested review from Lee-W and eladkal May 21, 2025 15:29
Lee-W
Lee-W reviewed May 22, 2025
View reviewed changes
@jroachgolf84 jroachgolf84 requested a review from Lee-W May 22, 2025 12:11
@jroachgolf84
Copy link
Collaborator Author

jroachgolf84 commented May 23, 2025

cc: @eladkal , @Lee-W , do you mind taking a look at the updated PR?

@kaxil kaxil merged commit 1e79418 into apache:main May 23, 2025
96 checks passed
@eladkal eladkal mentioned this pull request May 23, 2025
Closed
1 task
dadonnelly316 pushed a commit to dadonnelly316/airflow that referenced this pull request May 26, 2025
@jroachgolf84 @dadonnelly316
Merging TimeSensorAsync with TimeSensor (apache#50864)
9f50e24 
Per apache#50812, merging the `TimeSensorAsync` Sensor with `TimeSensor`, and adding deferrable mode.
@potiuk potiuk added this to the Airflow 3.0.2 milestone May 29, 2025
@potiuk
Copy link
Member

potiuk commented May 29, 2025

If the #51192 is merged + cherry-picked to 3.0.2 -> we should also cherry-pick this one to get latest standard provider examples.

sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
@jroachgolf84 @sanederchik
Merging TimeSensorAsync with TimeSensor (apache#50864)
1711f3e 
Per apache#50812, merging the `TimeSensorAsync` Sensor with `TimeSensor`, and adding deferrable mode.
@eladkal eladkal mentioned this pull request Jun 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaxil kaxil kaxil approved these changes

@gopidesupavan gopidesupavan Awaiting requested review from gopidesupavan

@eladkal eladkal Awaiting requested review from eladkal

@Lee-W Lee-W Awaiting requested review from Lee-W

Assignees

No one assigned

Labels

area:providers kind:documentation provider:standard

Projects

None yet

Milestone

Airflow 3.0.2

Development

Successfully merging this pull request may close these issues.

5 participants

@jroachgolf84 @potiuk @Lee-W @kaxil @eladkal