Skip to content

Bumping pinecone sdk to 7.0.0 to improve podspec handling #50868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amoghrajesh merged 5 commits into from
May 21, 2025
Merged

Bumping pinecone sdk to 7.0.0 to improve podspec handling #50868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bc9f9a7
Fixing mypy checks on pinecone provider
amoghrajesh May 21, 2025
f903e79
handling better
amoghrajesh May 21, 2025
74b8104
handling better
amoghrajesh May 21, 2025
000b45c
handling better
amoghrajesh May 21, 2025
0740844
bump pinecone to 7.0.0
amoghrajesh May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/pinecone/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ requires-python = "~=3.9"
# After you modify the dependencies, and rebuild your Breeze CI image with ``breeze ci-image build``
dependencies = [
"apache-airflow>=2.10.0",
"pinecone>=3.1.0",
"pinecone>=7.0.0",
]

[dependency-groups]
Expand Down
6 changes: 3 additions & 3 deletions providers/pinecone/src/airflow/providers/pinecone/hooks/pinecone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
from functools import cached_property
from typing import TYPE_CHECKING, Any

from pinecone import Pinecone, PodSpec, ServerlessSpec
from pinecone import Pinecone, PodSpec, PodType, ServerlessSpec

from airflow.hooks.base import BaseHook

Expand Down Expand Up @@ -182,7 +182,7 @@ def get_pod_spec_obj(
replicas: int | None = None,
shards: int | None = None,
pods: int | None = None,
pod_type: str | None = "p1.x1",
pod_type: str | PodType = PodType.P1_X1,
metadata_config: dict | None = None,
source_collection: str | None = None,
environment: str | None = None,
Expand All @@ -203,7 +203,7 @@ def get_pod_spec_obj(
replicas=replicas,
shards=shards,
pods=pods,
pod_type=pod_type,
pod_type=pod_type if isinstance(pod_type, PodType) else PodType(pod_type),
metadata_config=metadata_config,
source_collection=source_collection,
)
Expand Down