-
Notifications
You must be signed in to change notification settings - Fork 16.3k
feat (airflowctl): transition of Variable Command #50908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c7b36ac to
5d56a25
Compare
|
@bugraoz93 screencast.2025-05-24.16-47-53.mp4
In particular, the bulk response returns a 200 status code, but both result.success and result.errors are empty. This makes it challenging to determine if the operation was successful or if there were any issues. Could you please advise on the following:
Any guidance would be greatly appreciated! 🙏🏽 |
2f0cb0b to
0ac3cbb
Compare
|
Thanks for the progress @jx2lee! If something is wrong, we should fix it on the API end. Don't need to be in the scope of this PR for sure. I am going to check your questions in detail soon and will address them. |
e9ccc78 to
336ff23
Compare
|
@bugraoz93 Additionally, I've confirmed that the import/export commands are functioning correctly.
|
336ff23 to
1de0607
Compare
Make sense! That is the way to go. 🚀 Please cc me so I can follow up too :) |
bugraoz93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Great work!
|
@bugraoz93 Thanks! I'll make issue, soon 👍🏽 |
bugraoz93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change required after a change on the API side. Could you please adopt?
|
@bugraoz93 Sure, I'll adopt tonight. |
57dbf33 to
877b018
Compare
|
Thanks, @jx2lee! |
* init import/export in airflowctl variables * BulkCreateActionVariableBody.action to str
* init import/export in airflowctl variables * BulkCreateActionVariableBody.action to str
closes: #45669
Known Issues
action_on_existence Not Applied in Bulk Requests:
action_on_existenceparameter does not behave as expected.To address this, a separate issue has been created: #TO_BE_CONTINUED.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.