[v3-0-test] Docs assets.rst: use AssetAlias for alias in Metadata example (#50768)
#51000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a` example (#50768) This PR fixes an inconsistency in the `assets.rst` documentation example. The sample code used a plain string for the `alias` argument in `Metadata()`, which in reality raises: > TypeError: Key should be either an asset or an asset alias, not <class 'str'> This change updates the example to use a typed `AssetAlias("my-task-outputs")`, matching the SDK API and avoiding that error. (cherry picked from commit ed67114) Co-authored-by: QBidolet <52286815+QBidolet@users.noreply.github.com>
Lee-W
approved these changes
May 23, 2025
shahar1
approved these changes
May 24, 2025
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
…a` example (#50768) (#51000) This PR fixes an inconsistency in the `assets.rst` documentation example. The sample code used a plain string for the `alias` argument in `Metadata()`, which in reality raises: > TypeError: Key should be either an asset or an asset alias, not <class 'str'> This change updates the example to use a typed `AssetAlias("my-task-outputs")`, matching the SDK API and avoiding that error. (cherry picked from commit ed67114) Co-authored-by: QBidolet <52286815+QBidolet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an inconsistency in the
assets.rstdocumentation example.The sample code used a plain string for the
aliasargument inMetadata(), which in reality raises:This change updates the example to use a typed
AssetAlias("my-task-outputs"), matching the SDK API and avoiding that error.(cherry picked from commit ed67114)
Co-authored-by: QBidolet 52286815+QBidolet@users.noreply.github.com