Skip to content

Conversation

@gopidesupavan
Copy link
Member

@gopidesupavan gopidesupavan commented May 24, 2025

Adding gh workflow commands, to breeze to trigger workflows.

At present release managers have to do manually running the workflows on multiple repository. to make it easier, we can chain all the steps and run from local.

All the release managers should have already access to trigger workflows from the local.

When running the below command it does following:

  1. Validates given input tag is valid or not
  2. Triggers docs publish workflow in apache/airflow
  3. Waits for the workflow to finish
  4. Triggers workflow in apache/airflow-site repo to refresh the site
  5. Triggers S3 to GitHub sync
eg:
breeze workflow-run publish-docs --ref providers-zendesk/4.7.0 --refresh-site --sync-s3-to-github amazon apache.kafka

See the documentation for more options.

A sample console log from local(Note: i have used my personal repo ;) :

image image

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@gopidesupavan
Copy link
Member Author

image

@gopidesupavan
Copy link
Member Author

Still UI option is available to trigger :)

@gopidesupavan gopidesupavan added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label May 25, 2025
@gopidesupavan gopidesupavan requested a review from jscheffl May 25, 2025 10:57
@jscheffl jscheffl force-pushed the add-breeze-cmd-for-workflows branch from 1b3911a to 1645280 Compare May 25, 2025 11:51
Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Great addition. Small nit :)

Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>
@gopidesupavan
Copy link
Member Author

@potiuk currently the breeze command has this option --refresh-site --sync-s3-to-github , if it provides then it refreshes and syncs, is this fine or should we default them to always true. ?

@gopidesupavan gopidesupavan merged commit 7bd29f4 into apache:main May 25, 2025
96 checks passed
@github-actions
Copy link

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 7bd29f4 v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

dadonnelly316 pushed a commit to dadonnelly316/airflow that referenced this pull request May 26, 2025
* Add breeze commands for gh workflow docs publish

* Add breeze commands for gh workflow docs publish

* Add sync s3 to github workflow trigger

* Update dev/breeze/src/airflow_breeze/utils/gh_workflow_utils.py

Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>

---------

Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>
@potiuk
Copy link
Member

potiuk commented May 29, 2025

Nice!

@potiuk
Copy link
Member

potiuk commented May 29, 2025

@potiuk currently the breeze command has this option --refresh-site --sync-s3-to-github , if it provides then it refreshes and syncs, is this fine or should we default them to always true. ?

I think it would be better to revert it - make it true by default and alo --refresh-site/--no-refresh-site etc. Also we need to make sure to update dev/RELEASE* instructions to include those.. Have it it been also back-ported to v3-0-test @gopidesupavan ? Do you need my help here?

@gopidesupavan gopidesupavan deleted the add-breeze-cmd-for-workflows branch May 31, 2025 09:48
@gopidesupavan
Copy link
Member Author

@potiuk currently the breeze command has this option --refresh-site --sync-s3-to-github , if it provides then it refreshes and syncs, is this fine or should we default them to always true. ?

I think it would be better to revert it - make it true by default and alo --refresh-site/--no-refresh-site etc. Also we need to make sure to update dev/RELEASE* instructions to include those.. Have it it been also back-ported to v3-0-test @gopidesupavan ? Do you need my help here?

hard time last few days, agree will check this one today.

@gopidesupavan
Copy link
Member Author

We run from main right, thought do we need backport?

@potiuk
Copy link
Member

potiuk commented May 31, 2025

hard time last few days, agree will check this one today.

Absolutely no worries Pavan. We all have lives :) . I hppe all is fine.

@potiuk
Copy link
Member

potiuk commented May 31, 2025

We run from main right, thought do we need backport?

We will need backport, yes for Airflow docs

gopidesupavan added a commit to gopidesupavan/airflow that referenced this pull request Jun 2, 2025
* Add breeze commands for gh workflow docs publish

* Add breeze commands for gh workflow docs publish

* Add sync s3 to github workflow trigger

* Update dev/breeze/src/airflow_breeze/utils/gh_workflow_utils.py

Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>

---------

Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>
potiuk pushed a commit that referenced this pull request Jun 2, 2025
* Add breeze commands for gh workflow docs publish (#51036)

* Add breeze commands for gh workflow docs publish

* Add breeze commands for gh workflow docs publish

* Add sync s3 to github workflow trigger

* Update dev/breeze/src/airflow_breeze/utils/gh_workflow_utils.py

Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>

---------

Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>

* Update GH cli bool inputs to convert to string format in breeze and input branch to refresh site and sync s3 to github (#51093)

* Update GH cli bool inputs to convert to string format in breeze

* Update branch name to airflow-site-archive trigger

* DOCS: Remove site-refresh/sync-s3-to-github and Update release documentation instructions (#51259)

* Remove refres sit and sync s3 to github docs args

* Update release readme files

* Update release readme files

---------

Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>
@gopidesupavan
Copy link
Member Author

hard time last few days, agree will check this one today.

Absolutely no worries Pavan. We all have lives :) . I hppe all is fine.

Yeah all okay :)

kaxil pushed a commit that referenced this pull request Jun 3, 2025
* Add breeze commands for gh workflow docs publish (#51036)

* Add breeze commands for gh workflow docs publish

* Add breeze commands for gh workflow docs publish

* Add sync s3 to github workflow trigger

* Update dev/breeze/src/airflow_breeze/utils/gh_workflow_utils.py

Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>

---------

Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>

* Update GH cli bool inputs to convert to string format in breeze and input branch to refresh site and sync s3 to github (#51093)

* Update GH cli bool inputs to convert to string format in breeze

* Update branch name to airflow-site-archive trigger

* DOCS: Remove site-refresh/sync-s3-to-github and Update release documentation instructions (#51259)

* Remove refres sit and sync s3 to github docs args

* Update release readme files

* Update release readme files

---------

Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
* Add breeze commands for gh workflow docs publish

* Add breeze commands for gh workflow docs publish

* Add sync s3 to github workflow trigger

* Update dev/breeze/src/airflow_breeze/utils/gh_workflow_utils.py

Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>

---------

Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>
jose-lehmkuhl pushed a commit to jose-lehmkuhl/airflow that referenced this pull request Jul 11, 2025
* Add breeze commands for gh workflow docs publish

* Add breeze commands for gh workflow docs publish

* Add sync s3 to github workflow trigger

* Update dev/breeze/src/airflow_breeze/utils/gh_workflow_utils.py

Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>

---------

Co-authored-by: Bugra Ozturk <bugraoz93@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants