Add pre-commit detection for malicious unicode chars #51050
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
amoghrajesh,
ashb,
gopidesupavan,
jedcunningham and
potiuk
as code owners
jscheffl
added
backport-to-v3-1-test
| files: ^\.github/workflows/.*$|^\.github/actions/.*$ | ||
| require_serial: true | ||
| entry: zizmor | ||
| - repo: https://github.com/lirantal/anti-trojan-source |
Member
There was a problem hiding this comment.
Looks like no activity on this repo since last 3 years. not sure are they are maintaining it or not.
Contributor
Author
There was a problem hiding this comment.
Good point. Was just picking the first I could find.
Contributor
Author
There was a problem hiding this comment.
As further discussed in https://apache-airflow.slack.com/archives/C015SLQF059/p1748180085592359 --- maybe we rather roll-our own as the list to cover is way larger than the pre-commit I proposed here.
Contributor
Author
|
At least ＇ char FF07 FULLWIDTH APOSTROPHE was not taken seroious by the pre-commit. |
Contributor
Author
|
Closing as not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wake-up call after reading https://daniel.haxx.se/blog/2025/05/16/detecting-malicious-unicode/
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.