feat: merge TimeDeltaSensorAsync to TimeDeltaSensor #51133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
jameshyphen
force-pushed
the
feat_merge-timedeltasensor-async
branch
from
0013061 to
76d640f
Compare
Lee-W
reviewed
May 28, 2025
providers/standard/src/airflow/providers/standard/sensors/time_delta.py
Outdated
Show resolved
Hide resolved
jameshyphen
force-pushed
the
feat_merge-timedeltasensor-async
branch
3 times, most recently
from
2919606 to
8920c7b
Compare
Lee-W
approved these changes
May 29, 2025
providers/standard/src/airflow/providers/standard/sensors/time_delta.py
Outdated
Show resolved
Hide resolved
jameshyphen
force-pushed
the
feat_merge-timedeltasensor-async
branch
from
eb8e0bc to
b5f7512
Compare
…_delta.py Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jameshyphen
force-pushed
the
feat_merge-timedeltasensor-async
branch
from
b5b556f to
39ac8ac
Compare
eladkal
approved these changes
May 29, 2025
Contributor
|
merging. Test failures are not related to this PR |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Member
|
If the #51192 is merged + cherry-picked to 3.0.2 -> we should also cherry-pick this one to get latest standard provider examples. |
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* feat: merge TimeDeltaSensorAsync to TimeDeltaSensor * feat: add a test for deferrable TimeDeltaSensor * feat: add example, simplify code in TimeDeltaSensor (as per TimeSensor) * feat: PR comments & adapt failing tests due to deprecation * feat: get rid of airflow_venv/ from gitignore * feat: remove unused variables * Update providers/standard/src/airflow/providers/standard/sensors/time_delta.py Co-authored-by: Wei Lee <weilee.rx@gmail.com> * feat: resolve test errors --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jose-lehmkuhl
pushed a commit
to jose-lehmkuhl/airflow
that referenced
this pull request
Jul 11, 2025
* feat: merge TimeDeltaSensorAsync to TimeDeltaSensor * feat: add a test for deferrable TimeDeltaSensor * feat: add example, simplify code in TimeDeltaSensor (as per TimeSensor) * feat: PR comments & adapt failing tests due to deprecation * feat: get rid of airflow_venv/ from gitignore * feat: remove unused variables * Update providers/standard/src/airflow/providers/standard/sensors/time_delta.py Co-authored-by: Wei Lee <weilee.rx@gmail.com> * feat: resolve test errors --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow TimeDeltaSensor to act as a deferrable by consuming a feature flag.
Added a deprecation warning for TimeDeltaSensorAsync to nudge users to use TimeDeltaSensor with deferrable=True instead.
Tests
Related Issues
Closes #50811
Checklist