[KubernetesPodOperator] Added detection of terminated pod during reattach #51158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutomationDev85
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
jason810496
reviewed
Jun 4, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Thanks for the PR. LGTM for the change, but the k8s test still need to be fixed.
AutomationDev85
requested review from
ashb,
gopidesupavan and
potiuk
as code owners
AutomationDev85
force-pushed
the
feature/kubernetespodoperator-detect-terminated-pod-during-reconnect
branch
3 times, most recently
from
a82d025 to
8b2cbeb
Compare
AutomationDev85
force-pushed
the
feature/kubernetespodoperator-detect-terminated-pod-during-reconnect
branch
from
8b2cbeb to
6c011de
Compare
jscheffl
approved these changes
Jun 6, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Looks good to me... let's have CI green and then LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
During working with the KubernetesPodOperator we found the issue that sometimes the POD was already in terminated state and then KubernetesPodOperator tries to reconnect to this pod. But if the xcom sidecar is not running any more it makes no sense to work with this pod. Idea is to check if the pod is terminated then then delete the POD and create a new POD to run the task.
Details of change: