Fix widget error for core hooks #51168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
rawwar and
shubhamraj-git
as code owners
pierrejeambrun
added
the
backport-to-v3-1-test
2 tasks
bugraoz93
approved these changes
May 28, 2025
amoghrajesh
approved these changes
May 28, 2025
sunank200
approved these changes
May 30, 2025
pierrejeambrun
force-pushed
the
fix-widget-error
branch
from
5bdb00a to
25843c6
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jun 2, 2025
* Fix widget error for core hooks * Fix CI (cherry picked from commit 4fd29c5) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Backport successfully created: v3-0-test
|
Member
Author
|
This makes me realize that even before that PR we were storing mocked non core hooks in the Providers manager. Now all of them are mocked and in the cache, that's not a big deal because the api server process does not use the |
pierrejeambrun
added a commit
that referenced
this pull request
Jun 2, 2025
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* Fix widget error for core hooks * Fix CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix widget warning error:
That's caused in core hooks, because those are initialized when instanciating the ProvidersManager and then cached. (ProvidersManager is a singleton therefore we end up with unmocked hooks in the
hook_metaendpoint).After the fix, no more error, we have the form available in the front-end for the fs hook:
