-
Notifications
You must be signed in to change notification settings - Fork 16.3k
fix: allow configmap and secret references in the apiServer.env field #51191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow configmap and secret references in the apiServer.env field #51191
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
cb23da6 to
4e3f5b7
Compare
29ca1e0 to
8615e7f
Compare
The Helm schema validation for `apiServer.env` should allow specifying static values, values from ConfigMaps, and values from Secrets, the same as all of the other services. Update the values.schema.json so that the apiServer env schema matches the schema from the other services, e.g. the schema for webserver. Resolves apache#51190 Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
8615e7f to
4f01bfe
Compare
romsharon98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static checks fail
|
@LucasRoesler Congrats on your first PR 🥳 |
The Helm schema validation for
apiServer.envshould allow specifying static values, values from ConfigMaps, and values from Secrets, the same as all of the other services.Update the
values.schema.jsonso that theapiServer.envschema matches the schema from the other services, e.g. the schema for webserver.Closes #51190