Skip to content

Conversation

@LucasRoesler
Copy link
Contributor

The Helm schema validation for apiServer.env should allow specifying static values, values from ConfigMaps, and values from Secrets, the same as all of the other services.

Update the values.schema.json so that the apiServer.env schema matches the schema from the other services, e.g. the schema for webserver.

Closes #51190

@boring-cyborg
Copy link

boring-cyborg bot commented May 29, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@LucasRoesler LucasRoesler force-pushed the fix-api-server-env-schema-validation branch 2 times, most recently from cb23da6 to 4e3f5b7 Compare June 5, 2025 07:10
@LucasRoesler LucasRoesler force-pushed the fix-api-server-env-schema-validation branch from 29ca1e0 to 8615e7f Compare June 10, 2025 11:29
@eladkal eladkal requested a review from romsharon98 June 13, 2025 20:00
The Helm schema validation for `apiServer.env` should allow specifying
static values, values from ConfigMaps, and values from Secrets, the same
as all of the other services.

Update the values.schema.json so that the apiServer env schema matches
the schema from the other services, e.g. the schema for webserver.

Resolves apache#51190

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
@LucasRoesler LucasRoesler force-pushed the fix-api-server-env-schema-validation branch from 8615e7f to 4f01bfe Compare June 17, 2025 07:16
Copy link
Contributor

@romsharon98 romsharon98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static checks fail

@romsharon98 romsharon98 merged commit 27f7727 into apache:main Jun 22, 2025
67 checks passed
@romsharon98
Copy link
Contributor

@LucasRoesler Congrats on your first PR 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incorrect helm chart validation for apiServer.env field

2 participants