Skip to content

[v3-0-test] Update TaskLogContent to support virtualized rendering (#50746) #51202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kaxil merged 2 commits into from
Jun 3, 2025
Merged

[v3-0-test] Update TaskLogContent to support virtualized rendering (#50746) #51202

kaxil merged 2 commits into from
Jun 3, 2025

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented May 29, 2025

  • Update TaskLogContent to support virtualized rendering

  • Update TaskLogPreview and Logs to handle undefined parsedLogs
    (cherry picked from commit 813f3e3)

Co-authored-by: Guan Ming(Wesley) Chiu 105915352+guan404ming@users.noreply.github.com

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label May 29, 2025
@github-actions github-actions bot mentioned this pull request May 29, 2025
Merged
@jason810496 jason810496 self-requested a review June 1, 2025 07:12
@potiuk potiuk marked this pull request as ready for review June 2, 2025 10:42
pierrejeambrun
pierrejeambrun reviewed Jun 3, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static checks need fixing.

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Jun 3, 2025

cc: @bbovenzi (merger) @guan404ming (author)

@kaxil
Copy link
Member

kaxil commented Jun 3, 2025

Could we fix this possibly in next 20-30 mins? If not, I will have to move this to 3.0.3

@guan404ming
Copy link
Member

guan404ming commented Jun 3, 2025 •
edited
Loading

This type error happened since the upstream PR #50547 is not cherry picked here but it does not affect the function work in this PR even it doesn't picked here. Should we add it in or just fix the static error here. If so, I think I currently don't have permission to push to this branch. But change is simple is just in useLogs.tsx:

- accept?: "*/*" | "application/json" | "application/x-ndjson";
+ accept?: "*/*" | "application/json" | "text/plain";

maybe someone has permission could help with this, thanks!

@jason810496 @pierrejeambrun
Fix OpenAPI schema for get_log API (#50547)
f7e2d25 
* Fix openapi schema for get_log API

* Fix test_log

(cherry picked from commit 08cc57d)
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Jun 3, 2025

Needed backport PR first: #51357

@guan404ming
Copy link
Member

guan404ming commented Jun 3, 2025

Thanks!

@guan404ming @pierrejeambrun
[v3-0-test] Update TaskLogContent to support virtualized rendering (#…
f248deb 
…50746)

* Update TaskLogContent to support virtualized rendering

* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)

Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
@pierrejeambrun pierrejeambrun force-pushed the backport-813f3e3-v3-0-test branch from 7696572 to f248deb Compare June 3, 2025 10:10
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Jun 3, 2025 •
edited
Loading

I just rebased this PR on top to anticipate the CI and make it mergeable faster

guan404ming
guan404ming approved these changes Jun 3, 2025
View reviewed changes
Copy link
Member

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static error fixed, thanks for the rebase.

@kaxil kaxil merged commit 1ef6852 into v3-0-test Jun 3, 2025
71 checks passed
@kaxil kaxil deleted the backport-813f3e3-v3-0-test branch June 3, 2025 10:57
kaxil pushed a commit that referenced this pull request Jun 3, 2025
@github-actions @jason810496
@guan404ming @kaxil
[v3-0-test] Update TaskLogContent to support virtualized rendering (#…
6beae57 
…50746) (#51202)

* Fix OpenAPI schema for `get_log` API (#50547)

* Fix openapi schema for get_log API

* Fix test_log

(cherry picked from commit 08cc57d)

* [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746)

* Update TaskLogContent to support virtualized rendering

* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)

Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>

---------

Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
@kaxil kaxil mentioned this pull request Jun 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrejeambrun pierrejeambrun pierrejeambrun left review comments

@jason810496 jason810496 jason810496 approved these changes

@guan404ming guan404ming guan404ming approved these changes

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@rawwar rawwar Awaiting requested review from rawwar rawwar is a code owner

@bugraoz93 bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner

Assignees

No one assigned

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pierrejeambrun @kaxil @guan404ming @jason810496