Significantly speed up Pytest bootstrapping on MacOS in Breeze #51223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootstrapping of pytest - especially on MacOS in Breeze could take a long time - and it turns out it was because of rglob trying to check if any of the pyproject.toml/provider.yaml files changed and looking for "deprecation ignores". Both were using rglob, and it turned out that even just rglobbing providers folder takes significant amount of time with MacOS docker - because of the slow filesystem. This has been replaced now with: * for pyproject.toml/provider.yaml - we use the main airflow pyproject.toml to know exactly which pyproject.toml/provider.yaml to look for (we have them in workspace definition) * for deprecations_ignores - we hardcode the short list of the ignores we have.
potiuk
requested review from
amoghrajesh,
ashb,
gopidesupavan and
jedcunningham
as code owners
Member
Author
|
The difference locally or on linux is small (1 -> 0.3 sec), but on MacOS it's huge (10 s (!) -> less than 1 s) for just running or not running .rglob() |
Member
Author
|
cc: @ambika-garg -> I think that's something you noticed. |
potiuk
added
the
backport-to-v3-1-test
ephraimbuddy
approved these changes
May 30, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2025
…reeze (#51223) Bootstrapping of pytest - especially on MacOS in Breeze could take a long time - and it turns out it was because of rglob trying to check if any of the pyproject.toml/provider.yaml files changed and looking for "deprecation ignores". Both were using rglob, and it turned out that even just rglobbing providers folder takes significant amount of time with MacOS docker - because of the slow filesystem. This has been replaced now with: * for pyproject.toml/provider.yaml - we use the main airflow pyproject.toml to know exactly which pyproject.toml/provider.yaml to look for (we have them in workspace definition) * for deprecations_ignores - we hardcode the short list of the ignores we have. (cherry picked from commit 86b0c82) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Backport successfully created: v3-0-test
|
potiuk
added a commit
that referenced
this pull request
May 30, 2025
…reeze (#51223) (#51234) Bootstrapping of pytest - especially on MacOS in Breeze could take a long time - and it turns out it was because of rglob trying to check if any of the pyproject.toml/provider.yaml files changed and looking for "deprecation ignores". Both were using rglob, and it turned out that even just rglobbing providers folder takes significant amount of time with MacOS docker - because of the slow filesystem. This has been replaced now with: * for pyproject.toml/provider.yaml - we use the main airflow pyproject.toml to know exactly which pyproject.toml/provider.yaml to look for (we have them in workspace definition) * for deprecations_ignores - we hardcode the short list of the ignores we have. (cherry picked from commit 86b0c82) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Member
|
Oh thats nice one :) |
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
…reeze (#51223) (#51234) Bootstrapping of pytest - especially on MacOS in Breeze could take a long time - and it turns out it was because of rglob trying to check if any of the pyproject.toml/provider.yaml files changed and looking for "deprecation ignores". Both were using rglob, and it turned out that even just rglobbing providers folder takes significant amount of time with MacOS docker - because of the slow filesystem. This has been replaced now with: * for pyproject.toml/provider.yaml - we use the main airflow pyproject.toml to know exactly which pyproject.toml/provider.yaml to look for (we have them in workspace definition) * for deprecations_ignores - we hardcode the short list of the ignores we have. (cherry picked from commit 86b0c82) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
…e#51223) Bootstrapping of pytest - especially on MacOS in Breeze could take a long time - and it turns out it was because of rglob trying to check if any of the pyproject.toml/provider.yaml files changed and looking for "deprecation ignores". Both were using rglob, and it turned out that even just rglobbing providers folder takes significant amount of time with MacOS docker - because of the slow filesystem. This has been replaced now with: * for pyproject.toml/provider.yaml - we use the main airflow pyproject.toml to know exactly which pyproject.toml/provider.yaml to look for (we have them in workspace definition) * for deprecations_ignores - we hardcode the short list of the ignores we have.
jose-lehmkuhl
pushed a commit
to jose-lehmkuhl/airflow
that referenced
this pull request
Jul 11, 2025
…e#51223) Bootstrapping of pytest - especially on MacOS in Breeze could take a long time - and it turns out it was because of rglob trying to check if any of the pyproject.toml/provider.yaml files changed and looking for "deprecation ignores". Both were using rglob, and it turned out that even just rglobbing providers folder takes significant amount of time with MacOS docker - because of the slow filesystem. This has been replaced now with: * for pyproject.toml/provider.yaml - we use the main airflow pyproject.toml to know exactly which pyproject.toml/provider.yaml to look for (we have them in workspace definition) * for deprecations_ignores - we hardcode the short list of the ignores we have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrapping of pytest - especially on MacOS in Breeze could take a long time - and it turns out it was because of rglob trying to check if any of the pyproject.toml/provider.yaml files changed and looking for "deprecation ignores". Both were using rglob, and it turned out that even just rglobbing providers folder takes significant amount of time with MacOS docker - because of the slow filesystem.
This has been replaced now with:
for pyproject.toml/provider.yaml - we use the main airflow pyproject.toml to know exactly which pyproject.toml/provider.yaml to look for (we have them in workspace definition)
for deprecations_ignores - we hardcode the short list of the ignores we have.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.