Fix EksPodOperator in deferrable mode
#51255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
requested review from
eladkal,
hussein-awala,
jedcunningham and
o-nikolas
as code owners
boring-cyborg
bot
added
area:providers
provider:amazon
o-nikolas
reviewed
May 30, 2025
Contributor
o-nikolas
left a comment
o-nikolas
left a comment
There was a problem hiding this comment.
Is it possible to add some unit tests?
Contributor
Author
I'll try, I am not sure I'll be able to reproduce it with a unit test but I'll give it a shot |
Contributor
Author
There was no test to cover the |
vincbeck
force-pushed
the
vincbeck/fix_eks
branch
from
f255500 to
1f47443
Compare
o-nikolas
approved these changes
Jun 2, 2025
vincbeck
force-pushed
the
vincbeck/fix_eks
branch
from
1f47443 to
a9ed784
Compare
vincbeck
force-pushed
the
vincbeck/fix_eks
branch
from
f97e215 to
4aefb08
Compare
Contributor
Author
|
Failure unrelated to the PR, merging |
2 tasks
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
EksPodOperatorwhen run in deferrable mode. The methodtrigger_reentryuses the variable instanceconfig_filebut this one might not be defined. The methodtrigger_reentryis executed when the task is resumed and can be executed in a different machine than the one which executed theexecutemethod.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.