Add extra_credentials and roles to TrinoHook #51298
Merged
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahar1
approved these changes
Jun 2, 2025
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* Add extra_credentials and roles to TrinoHook * Address Trino provider doc URL error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: No existing issue that I could find. I'm happy to create one if that is preferred.
What?
Adds two optional parameters to the
TrinoHook's extra JSON. This PR generally follows these 2 similar past PRs: #27095 and #27213extra_credentialparameter in theTrinoHookextra payload.rolesparameter in theTrinoHookextra payload.Why?
TrinoHookallows for the use of these fields, and we would like to use the official TrinoHook rather than maintain a custom subclass which exposes these options.extra_credentialandrolesis available in Airflow's current pinned version of the Trino python client (0.334.0).