Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jun 3, 2025

Introduced by #51084


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Jun 3, 2025

cc: @kacpermuda

@potiuk potiuk force-pushed the fix-doc-error-openlineage branch from 4707e4b to c5ac0ac Compare June 3, 2025 10:04
@potiuk
Copy link
Member Author

potiuk commented Jun 3, 2025

Interesting that docs build did not run for the original PR -> checking selective checks

@potiuk
Copy link
Member Author

potiuk commented Jun 3, 2025

Selective check fix #51358

Copy link
Contributor

@kacpermuda kacpermuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've run pre-commit, but maybe it did not catch that.

@potiuk
Copy link
Member Author

potiuk commented Jun 3, 2025

Thanks, I've run pre-commit, but maybe it did not catch that.

It's doc building (not in pre-commit -too long) -> and selectiuve checks were also not catching that docs should be built - fixed in #51358

@kacpermuda
Copy link
Contributor

Ah, makes sense, assumed it was some formatting issue like ruff pre-commit.

@potiuk potiuk merged commit d07f918 into apache:main Jun 3, 2025
69 checks passed
@potiuk potiuk deleted the fix-doc-error-openlineage branch June 3, 2025 11:32
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants