-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add MessageDeduplicationId support to SnsPublishOperator
#51383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Thanks @seanghaeli You can fix static checks locally by running |
MessageDeduplicationId support to SnsPublishOperator
vincbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides static check failures, looks good!
I'd also strongly recommend enabling them to run automatically on every commit/push ( |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
|
Congrats @seanghaeli |
…51383) * Add MessageDeduplicationId support to SnsPublishOperator * Comply with pre-commit hooks * Add test cases for sns operator * Define constants for repetitive strings
Closes: #49841.
Add support for
MessageDeduplicationIdandMessageGroupIdinSnsPublishOperatorCurrently the
SnsPublishOperatordoes not support theMessageDeduplicationIdandMessageGroupIdparameters for AWS SNS FIFO topics. This limits users to relying only onContentBasedDeduplication, which does not cover all use cases. Added unit test coverage for FIFO topic scenarios for both the operator and the hook.Similar to #45051 which covers the same for AWS SQS.