Skip to content

Refactor migration with ctx manager to diable sqlite fkey #51392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jason810496 wants to merge 8 commits into from
Closed

Refactor migration with ctx manager to diable sqlite fkey #51392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
26ad735
Refactor migration with ctx manager to diable sqlite fkey
jason810496 Jun 4, 2025
94637ff
Enable migration tests for sqlite
jason810496 Jun 10, 2025
958bbc2
Skip check for sqlite+localExecutor for airflow 2
jason810496 Jun 11, 2025
8a34329
Fix export env order
jason810496 Jun 24, 2025
dd48f23
Skip check for all command
jason810496 Jul 1, 2025
a47c019
Try fix has_table("ab_user") check
jason810496 Jul 1, 2025
00d090c
Try fix "ab_user" validation with get_table_names()
jason810496 Jul 1, 2025
7fe74c3
Resolve conflict
jason810496 Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions .github/actions/migration_tests/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@ runs:
- name: "Test migration file 2 to 3 migration: ${{env.BACKEND}}"
shell: bash
run: |
breeze shell "${AIRFLOW_2_CMD}" --use-airflow-version 2.11.0 --answer y &&
breeze shell "export AIRFLOW__DATABASE__EXTERNAL_DB_MANAGERS=${DB_MANGERS}
${AIRFLOW_3_CMD}" --no-db-cleanup
breeze shell "export _AIRFLOW__SKIP_DATABASE_EXECUTOR_COMPATIBILITY_CHECK='1' &&
${AIRFLOW_2_CMD}" --use-airflow-version 2.11.0 --answer y &&
breeze shell "export _AIRFLOW__SKIP_DATABASE_EXECUTOR_COMPATIBILITY_CHECK='1' &&
export AIRFLOW__DATABASE__EXTERNAL_DB_MANAGERS=${env.DB_MANGERS} &&
${AIRFLOW_3_CMD}" --no-db-cleanup
env:
COMPOSE_PROJECT_NAME: "docker-compose"
DB_RESET: "false"
Expand All @@ -38,7 +40,6 @@ runs:
airflow db migrate --to-revision heads &&
airflow db downgrade -n 2.7.0 -y &&
airflow db migrate
if: env.BACKEND != 'sqlite'
- name: "Bring composer down"
shell: bash
run: breeze down
Expand All @@ -47,9 +48,11 @@ runs:
- name: "Test ORM migration 2 to 3: ${{env.BACKEND}}"
shell: bash
run: >
breeze shell "${AIRFLOW_2_CMD}" --use-airflow-version 2.11.0 --answer y &&
breeze shell "export AIRFLOW__DATABASE__EXTERNAL_DB_MANAGERS=${DB_MANGERS}
${AIRFLOW_3_CMD}" --no-db-cleanup
breeze shell "export _AIRFLOW__SKIP_DATABASE_EXECUTOR_COMPATIBILITY_CHECK='1' &&
${AIRFLOW_2_CMD}" --use-airflow-version 2.11.0 --answer y &&
breeze shell "export _AIRFLOW__SKIP_DATABASE_EXECUTOR_COMPATIBILITY_CHECK='1' &&
export AIRFLOW__DATABASE__EXTERNAL_DB_MANAGERS=${env.DB_MANGERS} &&
${AIRFLOW_3_CMD}" --no-db-cleanup
env:
COMPOSE_PROJECT_NAME: "docker-compose"
DB_RESET: "false"
Expand All @@ -60,7 +63,6 @@ runs:
airflow db migrate --to-revision heads &&
airflow db downgrade -n 2.7.0 -y &&
airflow db migrate
if: env.BACKEND != 'sqlite'
- name: "Bring compose down again"
shell: bash
run: breeze down
Expand All @@ -69,7 +71,8 @@ runs:
- name: "Test ORM migration ${{env.BACKEND}}"
shell: bash
run: >
breeze shell "export AIRFLOW__DATABASE__EXTERNAL_DB_MANAGERS=${DB_MANAGERS} &&
breeze shell "export _AIRFLOW__SKIP_DATABASE_EXECUTOR_COMPATIBILITY_CHECK='1' &&
export AIRFLOW__DATABASE__EXTERNAL_DB_MANAGERS=${env.DB_MANAGERS} &&
airflow db reset -y &&
airflow db migrate --to-revision heads &&
airflow db downgrade -n 2.7.0 -y &&
Expand All @@ -85,15 +88,14 @@ runs:
- name: "Test offline migration ${{env.BACKEND}}"
shell: bash
run: >
breeze shell
"export AIRFLOW__DATABASE__EXTERNAL_DB_MANAGERS=${DB_MANAGERS} &&
breeze shell "export _AIRFLOW__SKIP_DATABASE_EXECUTOR_COMPATIBILITY_CHECK='1' &&
export AIRFLOW__DATABASE__EXTERNAL_DB_MANAGERS=${env.DB_MANAGERS} &&
airflow db reset -y &&
airflow db downgrade -n 2.7.0 -y &&
airflow db migrate -s"
env:
COMPOSE_PROJECT_NAME: "docker-compose"
DB_MANAGERS: "airflow.providers.fab.auth_manager.models.db.FABDBManager"
if: env.BACKEND != 'sqlite'
- name: "Bring any containers left down"
shell: bash
run: breeze down
Expand Down
2 changes: 1 addition & 1 deletion airflow-core/docs/img/airflow_erd.sha256
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2e49ab99fe1076b0f3f22a52b9ee37eeb7fc20a5a043ea504cc26022f4315277
8e298c007f5604f2ddf278ee60f5a622f5a9c76220a55134805f74fbfadadfa3
Loading
Loading