feat: Add NominalTimeRunFacet to all OL events#51404
Merged
mobuchowski merged 1 commit intoapache:mainfrom Jun 4, 2025
Merged
Conversation
kacpermuda
force-pushed
the
feat-ol-nominal-run-facet
branch
from
5bb96f3 to
a540447
Compare
mobuchowski
approved these changes
Jun 4, 2025
Contributor
mobuchowski
left a comment
mobuchowski
left a comment
There was a problem hiding this comment.
Approved, one comment to think about
providers/openlineage/src/airflow/providers/openlineage/plugins/listener.py
Show resolved
Hide resolved
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently NominalTimeRunFacet is included in DAG START and TASK START OL events. This PR adds it to all other events.
Task does not have the "time it's supposed to run on", so it makes sense that we "inherit" it from DAG level.
Also adjusting the system tests for that change. I've also included system test changes related to recent changes in owner and tag fields, as I forgot to do it earlier.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.