Fix ECS reattach #51412
Merged
Fix ECS reattach #51412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
eladkal
reviewed
Jun 4, 2025
providers/amazon/src/airflow/providers/amazon/aws/operators/ecs.py
Outdated
Show resolved
Hide resolved
vincbeck
approved these changes
Jun 5, 2025
Contributor
vincbeck
left a comment
vincbeck
left a comment
There was a problem hiding this comment.
Some tests need to be updated but other than that, LGTM
Previously the ti primary key was used to create a UUID to uniquely identify which task started an ECS task, and if the same task was retried the same ECS Task could be used. However, operators now receive a RuntimeTaskInstance which does not have an equivalent key, so we now construct it with the attributes directly.
o-nikolas
force-pushed
the
onikolas/ecs_reattach_fix
branch
from
77ca74f to
f29a34d
Compare
eladkal
approved these changes
Jun 6, 2025
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
Previously the ti primary key was used to create a UUID to uniquely identify which task started an ECS task, and if the same task was retried the same ECS Task could be used. However, operators now receive a RuntimeTaskInstance which does not have an equivalent key, so we now construct it with the attributes directly.
kevinhongzl
pushed a commit
to kevinhongzl/airflow
that referenced
this pull request
Jun 7, 2025
Previously the ti primary key was used to create a UUID to uniquely identify which task started an ECS task, and if the same task was retried the same ECS Task could be used. However, operators now receive a RuntimeTaskInstance which does not have an equivalent key, so we now construct it with the attributes directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the ti primary key was used to create a UUID to identify which Airflow task started an ECS task, and if the same task was retried the same ECS Task could be used. However, operators now receive a RuntimeTaskInstance which does not have an equivalent key, so we now construct it with the attributes directly.
fixes #50742
Testing
Main:
A task retried, getting the same UUID (which would reattach, if this wasn't a somewhat mocked setup)
2.10.5
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.